Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Potential bug in TorchRunningMeanStd #47

Open
dominikonysz opened this issue Mar 6, 2024 · 2 comments
Open

[Bug]: Potential bug in TorchRunningMeanStd #47

dominikonysz opened this issue Mar 6, 2024 · 2 comments

Comments

@dominikonysz
Copy link
Contributor

During my debugging I came across the computation of the updated value for the running mean:

new_mean = mean + delta + batch_count / tot_count

It doesn't really influence me as I'm not using it right now but I feel like it should instead be:

new_mean = mean + delta * batch_count / tot_count 
@yuanmingqi
Copy link
Contributor

@roger-creus Hi Roger, can you check this issue?

@yuanmingqi
Copy link
Contributor

@dominikonysz We have uploaded the update and marked you as a co-author. Thank you for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants