Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess which checks should be in the R CMD check matrix #12

Open
jdhoffa opened this issue Jan 24, 2024 · 4 comments
Open

Assess which checks should be in the R CMD check matrix #12

jdhoffa opened this issue Jan 24, 2024 · 4 comments

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Jan 24, 2024

Relates to https://github.com/RMI-PACTA/demo_actions/blob/main/.github/workflows/R-CMD-check.yml

We may want to decide which and how many versions of R, operating systems, etc. we want to check against.

Relates to #13

@AlexAxthelm
Copy link
Contributor

As a note, we can define more than one matrix. one for "quick tests" to run on every push, and maybe an extended matrix to run in the merge queu (for repos that use that) or on main.

Not saying that's the right answer, but is an answer.

@AlexAxthelm AlexAxthelm transferred this issue from another repository Jan 24, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 2, 2024

Relates to RMI-PACTA/pacta.data.scraping#38

Worth considering that the ubuntu-latest seems to fail on this repo because of a timeout limit (15min). ubuntu checks in general are likely to take a while given the lack of ubuntu binaries.

@cjyetman
Copy link
Member

cjyetman commented Feb 2, 2024

Relates to RMI-PACTA/pacta.data.scraping#38

Worth considering that the ubuntu-latest seems to fail on this repo because of a timeout limit (15min). ubuntu checks in general are likely to take a while given the lack of ubuntu binaries.

totally true... but I've been considering running a weekly R CMD check on repos I maintain so that a cached version of the ubuntu-latest runner image is available, which might mitigate this a bit. I think the problem is that if no Action has run in a while, every package that has been updated since then has to be installed and compiled. Hoping that running it weekly will limit the number of new package versions.

@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 2, 2024

That's a super clever solution! Very much back it, and in general in favour to keep the ubuntu-latest check if it's feasible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants