-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: docker-check-R-sysdeps.yml
should only check sys deps of dependencies
#79
Comments
Hmm. Even upon first glance, this looked like a non-trivial problem to solve, but as I'm looking at it more closely, it's getting trickier. I think a reasonable approach would be to only check sysdeps for packages in The harder part here is in determining what sysreqs are actually relevant to include in an image. For example, the
which means that although there's no actual Requirements (and some are only needed at build-time), they're all getting picked up by The best solution would be if R had some way to distinguish between these, but I don't think that's coming any time soon, so maybe a better option would be to have an ignorelist, along the lines of "sysreqs_ignore": [
"arrow": ["C++17", "cmake"]
] But overall, I'm wondering if the better option is to drop this check, and have practical (in situ) testing check for missing dependencies instead. That would be tougher to set up on the front end, but we'd only get true positives. For example, if we're using |
confirmed that going with this is probably more ideal (and doesn't have the same problem)
Originally posted by @cjyetman in RMI-PACTA/workflow.data.preparation#221 (comment)
The text was updated successfully, but these errors were encountered: