Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider if has_consistent_fields_per_line() always reports the truth #6

Open
cjyetman opened this issue Nov 22, 2022 · 0 comments
Open

Comments

@cjyetman
Copy link
Member

cjyetman commented Nov 22, 2022

In RMI-PACTA/pacta.portfolio.analysis#175, guess_delimiter() was made to use stringr::str_count() to count the number of delimiters per line rather than use strsplit() to count the number of fields because strsplit() drops the last field if it is blank (or was removed because it's quoted). has_consistent_fields_per_line() may benefit from a similar treatment

if/when RMI-PACTA/pacta.portfolio.analysis#174 is complete, this issue should be transferred to pacta.portfolio.import

AB#10855

@cjyetman cjyetman transferred this issue from another repository Nov 26, 2022
@cjyetman cjyetman added the next label Apr 29, 2024
@jdhoffa jdhoffa added the ADO label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants