You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In RMI-PACTA/pacta.portfolio.analysis#175, guess_delimiter() was made to use stringr::str_count() to count the number of delimiters per line rather than use strsplit() to count the number of fields because strsplit() drops the last field if it is blank (or was removed because it's quoted). has_consistent_fields_per_line() may benefit from a similar treatment
if/when RMI-PACTA/pacta.portfolio.analysis#174 is complete, this issue should be transferred to pacta.portfolio.import
In RMI-PACTA/pacta.portfolio.analysis#175,
guess_delimiter()
was made to usestringr::str_count()
to count the number of delimiters per line rather than usestrsplit()
to count the number of fields becausestrsplit()
drops the last field if it is blank (or was removed because it's quoted).has_consistent_fields_per_line()
may benefit from a similar treatmentif/when RMI-PACTA/pacta.portfolio.analysis#174 is complete, this issue should be transferred to pacta.portfolio.import
AB#10855
The text was updated successfully, but these errors were encountered: