Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate data prior to prep_* functions #35

Open
AlexAxthelm opened this issue Oct 12, 2023 · 0 comments
Open

Aggregate data prior to prep_* functions #35

AlexAxthelm opened this issue Oct 12, 2023 · 0 comments

Comments

@AlexAxthelm
Copy link
Collaborator

Currently, a lot of code is repeated in each prep function to apply common filters and merges.

pacta.interactive.report/R/prep_trajectory_alignment.R

It'll be more efficient if the data aggregation and filtering were done once before applying plot-specific data wrangling. It would also make it easier to use the prep_* and plot_* functions independently even in cases where no peer or indices data are available. See for example how it is done in prep_data_executive_summary() in pacta.executive.summary.

And the application in workflow.transition.monitor

Migration of https://github.com/RMI-PACTA/pacta.interactive.report/issues/216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant