Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future tech bar chart might show least important companies instead of most important #82

Closed
cjyetman opened this issue Jun 10, 2024 · 2 comments · Fixed by #84
Closed
Labels

Comments

@cjyetman
Copy link
Member

cjyetman commented Jun 10, 2024

from user feedback (https://docs.google.com/spreadsheets/d/1tgeV4IsmqVZWExFcDKpjcmdqsG28VgcilPcM-OP5OW8/edit?gid=1322498032#gid=1322498032&range=13:13)

Why are all weights equal to 0%? Could it be that instead of the biggest companies in the portfolio the smallest were taken?

from @Antoine-Lalechere

I think in the company bar chart there is a mistake in the company we show. Companies order should be reversed (Honda be shown as first one of those fifteen companies as it gets the larger weight).
thumbnail_image001

AB#11177

@cjyetman cjyetman added the ADO label Jun 10, 2024
@cjyetman
Copy link
Member Author

possibly this

arrange(.data$port_weight, .by_group = TRUE) %>%

should be

arrange(dplyr::desc(.data$port_weight), .by_group = TRUE) %>% 

?

@Antoine-Lalechere
Copy link
Contributor

Antoine-Lalechere commented Jun 10, 2024

Yes and same one L31, if it's the last version of the code we use

cjyetman added a commit that referenced this issue Jun 11, 2024
- closes #82 

This needs serious review and testing. Just getting a hypothetical fix down for review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants