Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider parameterizing base image name/tag #48

Closed
cjyetman opened this issue Feb 26, 2024 · 1 comment
Closed

consider parameterizing base image name/tag #48

cjyetman opened this issue Feb 26, 2024 · 1 comment

Comments

@cjyetman
Copy link
Member

cjyetman commented Feb 26, 2024

https://github.com/RMI-PACTA/workflow.prepare.pacta.indices/blob/dd1e27d74ba8b24a9eedf744ef9553436c47f257/Dockerfile#L10C69-L10C77

ARG BASE_IMAGE=transitionmonitordockerregistry.azurecr.io/rmi_pacta:2021q4_1.0.0

The base image for the Dockerfile is hardcoded to rmi_pacta:2021q4_1.0.0, but the image to be used is probably dependent on which quarter benchmark data is being generated for, so it would be advantageous if the image name and/or tag were parameterized.

related #41
related #40 (comment)


Note: We could also consider using the auto built images on GHCR from workflow.transition.monitor as the base image since we're requiring loading in a local PACTA data set here.

@cjyetman
Copy link
Member Author

superseded by #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant