Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: rethink how pacta-data gets volume mounted in docker-compose.yml #88

Closed
jdhoffa opened this issue Feb 29, 2024 · 1 comment
Closed
Labels
upkeep maintenance, infrastructure, and similar

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 29, 2024

.env is used mainly to set R_CONFIG_ACTIVE and file paths. However, this R_CONFIG_ACTIVE parameter is mis-used a little to also set the target mount directory in the docker-compose.yml:

target: /pacta-data/${R_CONFIG_ACTIVE}

This is not really ideal, in case you want to set a project specific config (e.g. PA2023CH) that still uses 2023Q4 data

@jdhoffa jdhoffa added the upkeep maintenance, infrastructure, and similar label Feb 29, 2024
@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 29, 2024

Oops lol closing in favour of #63

@jdhoffa jdhoffa closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

1 participant