Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some basic logging #70

Open
jdhoffa opened this issue Nov 16, 2022 · 4 comments
Open

add some basic logging #70

jdhoffa opened this issue Nov 16, 2022 · 4 comments

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Nov 16, 2022

similar to pacta.data.preparation, so that we know what is going on, and where things are failing etc.

@cjyetman
Copy link
Member

FYI... there is this https://github.com/RMI-PACTA/pacta.portfolio.analysis/blob/main/R/write_log.R which we have used in the past to not flood stdout with messages making it difficult to parse, but still get important messages in the error log. It's not widely used though, tbh.

@jdhoffa
Copy link
Member Author

jdhoffa commented Nov 16, 2022

Hmmm. We should maybe consider how we treat logging. write_log feels like something that should actually exist in the workflow.transition.monitor repo. Or perhaps in a "workflow.utils" package.

But yes, that is useful.

I agree with not flooding STDOut, although I think some basic indication of what is going on could be helpful

@cjyetman
Copy link
Member

We also have a few cli::cli_h1() commands that do print to stdout, like...

cli::cli_h1("web_tool_script_1.R{get_build_version_msg()}")

but I'm not sure either will really help with what you're talking about, because they only work when there is not a problem. Errors do get sent to stdout though.

@cjyetman
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants