Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where rectangle and polygon were set inversely in the edit stage #125

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix bug where rectangle and polygon were set inversely in the edit stage #125

merged 2 commits into from
Aug 28, 2024

Conversation

DongyunRobotis
Copy link

  • Edit 후 새로 도형을 생성하는 과정에서 Segmentation과 Detection이 반대로 활성화 되는 부분을 수정하였습니다.

@DongyunRobotis
Update version.xml (1.1.0 -> 1.2.0)
7260ecc 
Signed-off-by: Dongyun Kim <kdy@robotis.com>
@DongyunRobotis DongyunRobotis marked this pull request as draft August 28, 2024 00:45
@jongsuff jongsuff added the bug Something isn't working label Aug 28, 2024
MilyangParkJaeHun
MilyangParkJaeHun approved these changes Aug 28, 2024
View reviewed changes
Copy link

@MilyangParkJaeHun MilyangParkJaeHun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그 픽스 사항 확인하였습니다
작업 수고하셨습니다!

seongminLee1027
seongminLee1027 approved these changes Aug 28, 2024
View reviewed changes
Copy link

@seongminLee1027 seongminLee1027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

jongsuff
jongsuff approved these changes Aug 28, 2024
View reviewed changes
Copy link

@jongsuff jongsuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버그픽스 확인했습니다.
이전부터 조건이 반대로 들어가있엇군요..

@jongsuff jongsuff marked this pull request as ready for review August 28, 2024 00:59
@jongsuff jongsuff merged commit b3c1e8d into develop Aug 28, 2024
2 checks passed
@jongsuff jongsuff deleted the feature-fix-shortcut branch August 28, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilyangParkJaeHun MilyangParkJaeHun MilyangParkJaeHun approved these changes

@seongminLee1027 seongminLee1027 seongminLee1027 approved these changes

@jongsuff jongsuff jongsuff approved these changes

@kjwoo31 kjwoo31 Awaiting requested review from kjwoo31

@HunJ93 HunJ93 Awaiting requested review from HunJ93

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DongyunRobotis @MilyangParkJaeHun @seongminLee1027 @jongsuff