2d CK group convolution backward and weight update solvers #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amberhassaan
requested review from
CAHEK7,
iq136boy,
DrizztDoUrden,
JehandadKhan and
averinevg
and removed request for
Dmantri98
|
@JehandadKhan , @junliume , I am closing this PR in favor of #2663 which contains the change-set of this PR plus some refactoring improvements to 3D convolution tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides CK-based Backward-Data and Backward-Weight update solvers for 2D Group Convolution. This completes the solver picture for 2D group convolutions (except for f8, which has its own solvers).
Also included in this PR is a generic design for the GTest Fixture class that handles 2D and 3D (Fwd,Bwd,Wrw) passes at the same time, so testing code can reuse this class and related macros. A future PR will use this class for 3D grouped conv gtests (arriving shortly).