-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_gitignore : adding .gitignore file #2611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and rest is good.
_readthedocs/ | ||
|
||
# avoid duplicating contributing.md due to conf.py | ||
docs/CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these lines needed? These could be legit files that we want in the repository.
@bghimireamd @JehandadKhan @atamazov We discussed about |
@junliume I do not know. I have my own .gitignore and do not need this. |
Oh! in that case we can place a hold on this PR. Documentation change was introduced by #2587 , which I believe generates some files during build process. To ignore those files this .gitinore was added. We can have our own local .gitignore. |
The good practice is not generating anything in the source directory. Ideally it should be read-only. |
My humble opinion is that it is common for projects to have a |
It depends - if you don't generate anything in the build directory - you don't need default project Each user makes |
In this PR we add .gitignore file. Currently the ignores are related to documenation.