From afbe3549af4d2e9c2746ea86c6a74708729c7b69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?kadir=20=C3=A7etinkaya?= Date: Thu, 19 Oct 2023 09:24:22 +0200 Subject: [PATCH] [clangd] Disable crashy unchecked-optional-access tidy check (#69427) Fixes https://github.com/llvm/llvm-project/issues/69369. Fixes https://github.com/clangd/clangd/issues/1700. (cherry picked from commit e63ab13c82e78f65baca48d5b5e4f6ea8d55dbc7) --- clang-tools-extra/clangd/TidyProvider.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clang-tools-extra/clangd/TidyProvider.cpp b/clang-tools-extra/clangd/TidyProvider.cpp index f101199a20cebf..2a6fba52e29bf4 100644 --- a/clang-tools-extra/clangd/TidyProvider.cpp +++ b/clang-tools-extra/clangd/TidyProvider.cpp @@ -219,6 +219,9 @@ TidyProvider disableUnusableChecks(llvm::ArrayRef ExtraBadChecks) { "-bugprone-use-after-move", // Alias for bugprone-use-after-move. "-hicpp-invalid-access-moved", + // Check uses dataflow analysis, which might hang/crash unexpectedly on + // incomplete code. + "-bugprone-unchecked-optional-access", // ----- Performance problems -----