Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flang][OpenMP] Change the lowering of max and min reduction operator #62

Closed
wants to merge 2 commits into from
Closed

[flang][OpenMP] Change the lowering of max and min reduction operator #62

wants to merge 2 commits into from

Commits on Apr 18, 2024

  1. [flang][OpenMP] Change the lowering of max and min reduction operator. 

    This patch changes the lowering of max and min to be lowered to
arith::MaxNumFop and arith::MinNumFOp instead of using arith::MaximumFOp and
arith::MinimumFOp to match the code generated in clang. The arith::MaximumFOp
and arith::MinimumFOp map to the corresponding intrinsics llvm.maximum.* and
llvm.minimum.* intrinsics which conform to the semantics specified in the draft
of IEEE 754-2019. which is not supported by all hardware. Instead using
arith::MaximumFOp and arith::MinimumFOp will allow code generation for more
targets and match the code generated by clang OpenMP.
    @jsjodin
    jsjodin committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2bea349 View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @jsjodin
    jsjodin committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7252648 View commit details
    Browse the repository at this point in the history