Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: coalesced_group member function ballot is missing #157

Open
songrui2009 opened this issue Aug 31, 2024 · 1 comment
Open

[Issue]: coalesced_group member function ballot is missing #157

songrui2009 opened this issue Aug 31, 2024 · 1 comment
Assignees

Comments

@songrui2009
Copy link

Problem Description

according to the document:
https://rocm.docs.amd.com/projects/HIP/en/docs-6.1.2/doxygen/html/amd__hip__cooperative__groups_8h_source.html
or higher ROCM version
coalesced_group::ballot can be enable by defintion HIP_ENABLE_WARP_SYNC_BUILTINS
but this is invalid

Operating System

ubuntu 22.04

CPU

AMD Ryzen 5 3600 6-Core Processor

GPU

AMD Radeon RX 7900 XTX, AMD Radeon RX 7900 XT

ROCm Version

ROCm 6.1.0

ROCm Component

HIP

Steps to Reproduce

-DHIP_ENABLE_WARP_SYNC_BUILTINS
...
namespace cg = cooperative_groups;
...
cg::coalesced_group thread_warp = cg::coalesced_threads(gg);
uint warp_done = thread_warp.ballot(1);

compile error:
error: no member named 'ballot' in 'cooperative_groups::coalesced_group'

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@Naraenda Naraenda assigned Naraenda and Snektron and unassigned Naraenda Sep 6, 2024
@Snektron
Copy link
Collaborator

Hi, sorry for the late response. This is not quite the right repo to make this issue in, I believe it should be best to make these kind of issues in https://github.com/ROCm/ROCm.

Regardless, I dug into it a bit for you, and it seems like the source thats reported on the ROCm docs page is not for the right branch. The ballot function isn't yet present in the header for ROCm 6.2.0 (see here), but it is present in the amd-staging version (see here). This usually means that it will be added in the next ROCm version.

I'll see if I can get that ROCm docs page fixed, there is probably something wrong there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Snektron @Naraenda @songrui2009 and others