Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNPs that do not have the highest PP are higlighted #13

Open
AMCalejandro opened this issue Nov 10, 2022 · 2 comments
Open

SNPs that do not have the highest PP are higlighted #13

AMCalejandro opened this issue Nov 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@AMCalejandro
Copy link

Hi Brian,

Sorry for the bad post but see an image of the finemapping plots.
I do not know if there is something going on in the selection of the top SNPs to highlight.

At the beginning I thought it could be related with the new names in the multifinemap df for the new version of FINEMAP but this is actually happening for susie as well.
The locus in the image is a case in which there is no consensus SNP, in case you think it might be related...
I cannot share the data for this but happy to have a chat.

If you try to reproduce with the roxygen example, please not the the toy data of locus plot is generated using a previous version of FINEMAP. Maybe worth getting the multifinemap dat with the latest version of FINEMAP, in case the issue is relared to this

image

@AMCalejandro AMCalejandro added the bug Something isn't working label Nov 10, 2022
@bschilder bschilder self-assigned this Nov 10, 2022
@bschilder
Copy link
Member

Hey @AMCalejandro , I actually just reworked the way echoplot highlights SNPs. Could you try upgrading and see if that helps? Thanks!

@AMCalejandro
Copy link
Author

If you are talking about the updates you made yesterday.
Yes, this is the plot after having run remotes::install_github("RajLabMSSM/echolocatoR") to pull the updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants