New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings (essentially pointers) as arguments can be nullable #16

Open

RamyElkest opened this issue Jul 10, 2018 · 1 comment

Owner

RamyElkest commented Jul 10, 2018 •

edited

Loading

For instance virDomainGetMetadata takes a uri string which is conditionally nullable

This should apply to virConnectOpen as well

This will probably apply to all pointer types

This means in our type check we should check for napi_null/napi_undefined as well as the type

The text was updated successfully, but these errors were encountered:

Owner Author

RamyElkest commented Aug 12, 2018

Note: additionally interface/wrapper arguments should default to null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment