Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quitting neuro triggers uncaught exception in Ranvier websocket-networking #8

Open
stennie opened this issue Oct 21, 2020 · 0 comments
Labels

Comments

@stennie
Copy link
Contributor

stennie commented Oct 21, 2020

Expected behaviour: Quitting neuro should gracefully disconnect from Ranvier before shutting down.

Actual behaviour: Quitting neuro drops the connection and triggers an uncaught server exception due to lack of error handling in websocket-networking (which would be fixed via RanvierMUD/websocket-networking#2).

The onus should probably be on the server in this case, but Neuro could also call disconnect for a more graceful shutdown.

@stennie stennie added the bug label Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant