Reuse Palladio build parent and create aggregated update site #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowball77
approved these changes
Nov 5, 2019
There was a problem hiding this comment.
I briefly went through the files. I am not an expert for the PCM Maven Tycho build but the changes I was able to see look reasonable. Another test we can do once it builds is to install and use it. I have models for it, so once I get a release I can review again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the build management tools used in Palladio.
This build considers more bundles than the old one. Therefore, it is not necessary to include an old SDM update site to collect bundles anymore.
At the end of the build, a common aggregated update site is created based on the two repositories that have been already defined. This common update site contains almost all bundles of the old update site (except of fujaba). Therefore, I consider it a replacement for the current nightly update site. After merging this PR, I will set up a build at the Palladio build server.