Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free energy is not computed for non-terminated graphs. #179

Open
albertpod opened this issue Nov 6, 2023 · 7 comments
Open

Free energy is not computed for non-terminated graphs. #179

albertpod opened this issue Nov 6, 2023 · 7 comments
Assignees

Comments

@albertpod
Copy link
Member

albertpod commented Nov 6, 2023

We have added predictvars feature for the inference function. Due to some theoretical concerns, the computation of the free energy when missings are present was left aside.

Now, if one wants to compute free energy on non terminated graph, he'll get

The Bethe Free Energy computation is not compatible with the prediction functionality. Set `free_energy = false` to suppress this error.

@ismailsenoz has some good insights on this one in relation to expected free energy. IMHO, we should pick it up.

@albertpod
Copy link
Member Author

@ismailsenoz, perhaps we just want to establish theoretical grounding. The implementation will be for another milestone.

@bvdmitri
Copy link
Member

@ismailsenoz
This task has been added to the milestone for tracking and prioritization.

@ismailsenoz
Copy link

We discussed with @albertpod that the heuristic of omitting entropies from the computation seems justified from theoretical grounds. Perhaps, we can discuss if further need be.

@albertpod
Copy link
Member Author

There's still a small realization bottleneck. Let's discuss this onsite.
Anyway, I would first address #180, and then we can code this one up.

@bvdmitri WDYT?

@bvdmitri
Copy link
Member

I'm up for the discussion. However, I think #180 is orthogonal to this one and we can start those simultaneously (not necessarily you of course)

@wouterwln
Copy link
Member

@albertpod @bvdmitri @ismailsenoz what is the status of this?

@wouterwln wouterwln removed this from the RxInfer update Nov 28th milestone Mar 15, 2024
@bvdmitri
Copy link
Member

I'm not the right person to poke about theoretical grounds of this, but again I'm open for discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👉 Assigned
Development

No branches or pull requests

4 participants