From bea62a0ced673107a99699294cfacdbe0b4c37bc Mon Sep 17 00:00:00 2001
From: kotesh-arya <koteswarraomudila@gmail.com>
Date: Fri, 6 Oct 2023 23:24:46 +0530
Subject: [PATCH 1/6] REFACTOR: replace /members with /users

---
 online-members/constants.js | 2 +-
 online-members/utils.js     | 2 +-
 task/script.js              | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/online-members/constants.js b/online-members/constants.js
index fb4f301c..1d6844e3 100644
--- a/online-members/constants.js
+++ b/online-members/constants.js
@@ -31,7 +31,7 @@ const TASKS_CLASS_LIST = ['task'];
 const TASKS_CONTAINER_CLASS_LIST = ['tasks-container'];
 
 // RDS Api Constants
-const RDS_API_MEMBERS = API_BASE_URL + '/members';
+const RDS_API_MEMBERS = API_BASE_URL + '/users';
 const RDS_API_TASKS_USERS = API_BASE_URL + '/tasks';
 const RDS_CLOUDINARY_CLOUD_URL = `https://res.cloudinary.com/realdevsquad/image/upload`;
 
diff --git a/online-members/utils.js b/online-members/utils.js
index d8ec1150..c6fc98b4 100644
--- a/online-members/utils.js
+++ b/online-members/utils.js
@@ -25,7 +25,7 @@ async function getMembersData() {
   const membersRequest = await makeApiCall(RDS_API_MEMBERS);
   if (membersRequest.status === 200) {
     membersList = await membersRequest.json();
-    membersList = membersList.members;
+    membersList = membersList.users;
     membersList = membersList.filter((member) => !member.incompleteUserDetails);
     membersList.forEach((member) => {
       memberObject[`${member.username}`] = {
diff --git a/task/script.js b/task/script.js
index 1e26f9db..a85e0d8b 100644
--- a/task/script.js
+++ b/task/script.js
@@ -435,11 +435,11 @@ async function fetchLevel() {
   }
 }
 
-async function fetchMembers() {
+async function fetchUsers() {
   try {
-    const response = await fetch(`${API_BASE_URL}/members`);
+    const response = await fetch(`${API_BASE_URL}/users`);
     const data = await response.json();
-    membersData = data.members;
+    membersData = data.users;
   } catch {
     return;
   }
@@ -447,7 +447,7 @@ async function fetchMembers() {
 
 fetchTags();
 fetchLevel();
-fetchMembers();
+fetchUsers();
 
 function filterMembers(searchInput) {
   clearSuggestionList();

From 3ef9517bf24d1b3973af6987aa8c514e5660c6d5 Mon Sep 17 00:00:00 2001
From: kotesh-arya <koteswarraomudila@gmail.com>
Date: Sat, 7 Oct 2023 15:37:08 +0530
Subject: [PATCH 2/6] TEST: using users mockdata

---
 __tests__/tasks/profile-picture.test.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/__tests__/tasks/profile-picture.test.js b/__tests__/tasks/profile-picture.test.js
index c06d707b..6e2eccd9 100644
--- a/__tests__/tasks/profile-picture.test.js
+++ b/__tests__/tasks/profile-picture.test.js
@@ -1,6 +1,6 @@
 const puppeteer = require('puppeteer');
 const API_BASE_URL = 'https://staging-api.realdevsquad.com';
-const { members } = require('../../mock-data/members');
+const { allUsersData } = require('../../mock-data/users');
 
 describe('Task Page - Assignee Profile Pic', () => {
   let browser;
@@ -20,7 +20,7 @@ describe('Task Page - Assignee Profile Pic', () => {
     page.on('request', (interceptedRequest) => {
       const url = interceptedRequest.url();
 
-      if (url === `${API_BASE_URL}/members`) {
+      if (url === `${API_BASE_URL}/users`) {
         interceptedRequest.respond({
           status: 200,
           contentType: 'application/json',
@@ -29,7 +29,7 @@ describe('Task Page - Assignee Profile Pic', () => {
             'Access-Control-Allow-Methods': 'GET, POST, PUT, DELETE, OPTIONS',
             'Access-Control-Allow-Headers': 'Content-Type, Authorization',
           },
-          body: JSON.stringify(members),
+          body: JSON.stringify(allUsersData),
         });
       } else {
         interceptedRequest.continue();
@@ -52,7 +52,7 @@ describe('Task Page - Assignee Profile Pic', () => {
 
   it('Profile picture with url', async () => {
     const inputElement = await page.$('input#assignee');
-    const name = 'satyam';
+    const name = 'Arpit_02';
 
     //Trigger the input event manually
     for (let i = 0; i < name.length; i++) {
@@ -64,7 +64,7 @@ describe('Task Page - Assignee Profile Pic', () => {
     await page.waitForTimeout(2000);
     const imgSrc = await page.$eval('#list-items img', (img) => img.src);
     const expectedImageFilename =
-      'https://res.cloudinary.com/imgprc/image/upload/v1688145505/profile/tu4zVmwFX91e9oEuSWLg/woqilcqdbp0cudcexkem.jpg';
+      'https://res.cloudinary.com/realdevsquad/image/upload/v1679878917/profile/54vObOfoscwiIVNMSqnN/askdcanhcehukqrdugge.jpg';
     expect(imgSrc.endsWith(expectedImageFilename)).toBe(true);
   });
 
@@ -75,7 +75,7 @@ describe('Task Page - Assignee Profile Pic', () => {
     await page.keyboard.press('Backspace');
     await new Promise((resolve) => setTimeout(resolve, 500));
 
-    const name = 'sumit';
+    const name = '19sriram';
     for (let i = 0; i < name.length; i++) {
       await inputElement.type(name[i], { delay: 100 });
     }

From c1f86126b80477fab54d880fb80e5d454f4a9b49 Mon Sep 17 00:00:00 2001
From: kotesh-arya <koteswarraomudila@gmail.com>
Date: Sun, 8 Oct 2023 21:27:34 +0530
Subject: [PATCH 3/6] REFACTOR: replace route, variable name

---
 __tests__/tasks/task-dependency.test.js | 2 +-
 online-members/constants.js             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/__tests__/tasks/task-dependency.test.js b/__tests__/tasks/task-dependency.test.js
index b2e3634a..148f9842 100644
--- a/__tests__/tasks/task-dependency.test.js
+++ b/__tests__/tasks/task-dependency.test.js
@@ -33,7 +33,7 @@ describe('Input box', () => {
           },
           body: JSON.stringify(levels),
         });
-      } else if (url === `${API_BASE_URL}/members`) {
+      } else if (url === `${API_BASE_URL}/users`) {
         interceptedRequest.respond({
           status: 200,
           contentType: 'application/json',
diff --git a/online-members/constants.js b/online-members/constants.js
index 1d6844e3..20bdd67d 100644
--- a/online-members/constants.js
+++ b/online-members/constants.js
@@ -31,7 +31,7 @@ const TASKS_CLASS_LIST = ['task'];
 const TASKS_CONTAINER_CLASS_LIST = ['tasks-container'];
 
 // RDS Api Constants
-const RDS_API_MEMBERS = API_BASE_URL + '/users';
+const RDS_API_USERS = API_BASE_URL + '/users';
 const RDS_API_TASKS_USERS = API_BASE_URL + '/tasks';
 const RDS_CLOUDINARY_CLOUD_URL = `https://res.cloudinary.com/realdevsquad/image/upload`;
 

From 45b5b6ae990cd0afde8696bbfc0c3bcd63b95184 Mon Sep 17 00:00:00 2001
From: kotesh-arya <koteswarraomudila@gmail.com>
Date: Wed, 11 Oct 2023 00:32:44 +0530
Subject: [PATCH 4/6] REFACTOR: variables and css-selectors to represent users

---
 online-members/constants.js        | 39 +++++++-------
 online-members/online-members.css  | 24 ++++-----
 online-members/online-members.html |  2 +-
 online-members/script.js           | 82 +++++++++++++++---------------
 online-members/sse-events.js       | 43 ++++++++--------
 online-members/utils.js            | 38 +++++++-------
 task/script.js                     | 10 ++--
 7 files changed, 117 insertions(+), 121 deletions(-)

diff --git a/online-members/constants.js b/online-members/constants.js
index 20bdd67d..df64e9a2 100644
--- a/online-members/constants.js
+++ b/online-members/constants.js
@@ -1,27 +1,24 @@
 'use strict';
 
-// Members Constants
-const MEMBERS_CLASS = 'members';
-const MEMBERS_CLASS_LIST = [MEMBERS_CLASS];
-const MEMBERS_UL_CLASS_LIST = ['members-list'];
-const MEMBERS_LIST_ID = 'members-list';
-const MEMBERS_CONTAINER_CLASS_LIST = ['members-container'];
-const MEMBERS_CONTAINER_ID = 'members-container';
-const MEMBERS_ONLINE_CLASS = 'members-online';
-const MEMBERS_ONLINE_HIDDEN_CLASS = 'members-online-hidden';
-const MEMBERS_ONLINE_CLASS_LIST = [
-  MEMBERS_ONLINE_CLASS,
-  MEMBERS_ONLINE_HIDDEN_CLASS,
-];
-
-const PROFILE_NAME_CLASS = 'members-profile-and-name';
+// Users Constants
+const USERS_CLASS = 'users';
+const USERS_CLASS_LIST = [USERS_CLASS];
+const USERS_UL_CLASS_LIST = ['users-list'];
+const USERS_LIST_ID = 'users-list';
+const USERS_CONTAINER_CLASS_LIST = ['users-container'];
+const USERS_CONTAINER_ID = 'users-container';
+const USERS_ONLINE_CLASS = 'users-online';
+const USERS_ONLINE_HIDDEN_CLASS = 'users-online-hidden';
+const USERS_ONLINE_CLASS_LIST = [USERS_ONLINE_CLASS, USERS_ONLINE_HIDDEN_CLASS];
+
+const PROFILE_NAME_CLASS = 'users-profile-and-name';
 const PROFILE_NAME_CLASS_LIST = [PROFILE_NAME_CLASS];
 
-// Members Search Constants
-const MEMBERS_SEARCH_CLASS_LIST = ['members-search'];
-const MEMBERS_SEARCH_INPUT_CLASS_LIST = ['members-search-input'];
-const MEMBERS_SEARCH_ID = 'search-members';
-const MEMBERS_SEARCH_PLACEHOLDER = 'Search for members';
+// Users Search Constants
+const USERS_SEARCH_CLASS_LIST = ['users-search'];
+const USERS_SEARCH_INPUT_CLASS_LIST = ['users-search-input'];
+const USERS_SEARCH_ID = 'search-users';
+const USERS_SEARCH_PLACEHOLDER = 'Search for users';
 
 // Task Constants
 const TASKS_CONTAINER_ID = 'task-container';
@@ -41,7 +38,7 @@ const RDS_SSE_ONLINE_URL = 'https://online.realdevsquad.com/online-members';
 const RDS_PROFILE_IMAGE_SIZE = 'w_40,h_40';
 const RDS_PROFILE_DEFAULT_IMAGE = '';
 
-const PROFILE_IMAGE_CLASS = 'members-profile';
+const PROFILE_IMAGE_CLASS = 'users-profile';
 const PROFILE_IMAGE_CLASS_LIST = [PROFILE_IMAGE_CLASS];
 
 /* MESSAGES CONSTANTS */
diff --git a/online-members/online-members.css b/online-members/online-members.css
index eeccc16c..14f693c4 100644
--- a/online-members/online-members.css
+++ b/online-members/online-members.css
@@ -35,7 +35,7 @@
   width: 100%;
 }
 
-.members-container {
+.users-container {
   margin: 10px;
   border: 2px solid black;
   border-radius: 5px;
@@ -44,11 +44,11 @@
   min-width: 260px;
 }
 
-.members-list {
+.users-list {
   overflow: hidden;
 }
 
-.members {
+.users {
   margin: 10px;
   padding: 0 5px;
   border: 2px solid black;
@@ -62,32 +62,32 @@
   background: #8abbcd;
 }
 
-.members:hover {
+.users:hover {
   background: #5992a7;
 }
 
-.members.dragging {
+.users.dragging {
   background: transparent;
   color: transparent;
   border: transparent;
 }
 
-.members-online {
+.users-online {
   width: 10px;
   height: 10px;
   background-color: rgb(58, 247, 58);
   border-radius: 50%;
 }
 
-.members-online-hidden {
+.users-online-hidden {
   display: none;
 }
 
-.members.scale {
+.users.scale {
   transform: scale(1.1);
 }
 
-.members-search {
+.users-search {
   margin: 10px;
   height: 4rem;
   width: 15rem;
@@ -98,18 +98,18 @@
   align-items: center;
 }
 
-.members-search-input {
+.users-search-input {
   height: 2rem;
   width: 15rem;
 }
 
-.members-profile {
+.users-profile {
   border-radius: 50%;
   width: 25px;
   margin-right: 5px;
 }
 
-.members-profile-and-name {
+.users-profile-and-name {
   display: flex;
   align-items: center;
 }
diff --git a/online-members/online-members.html b/online-members/online-members.html
index b98d0bf9..b6c9bfe7 100644
--- a/online-members/online-members.html
+++ b/online-members/online-members.html
@@ -21,7 +21,7 @@
       <!-- Task -->
       <div class="task-container" id="task-container"></div>
       <!-- Members -->
-      <div class="members-container" id="members-container"></div>
+      <div class="users-container" id="users-container"></div>
     </div>
     <footer>
       <p class="info-repo">
diff --git a/online-members/script.js b/online-members/script.js
index ab422ea8..8b9c861b 100644
--- a/online-members/script.js
+++ b/online-members/script.js
@@ -19,35 +19,35 @@ function createProfileImage(publicId = '', alt = '') {
     type: 'img',
     classList: PROFILE_IMAGE_CLASS_LIST,
   });
-  img.src = getMemberProfileImageLink(publicId);
+  img.src = getUserProfileImageLink(publicId);
   img.setAttribute('alt', alt);
   return img;
 }
 
-function createMemberNode(member) {
-  const memberDiv = createElement({
+function createUserNode(user) {
+  const userDiv = createElement({
     type: 'div',
-    classList: MEMBERS_CLASS_LIST,
+    classList: USERS_CLASS_LIST,
   });
-  memberDiv.dataset.username = member.username;
+  userDiv.dataset.username = user.username;
 
-  const memberOnlineDiv = createElement({
+  const userOnlineDiv = createElement({
     type: 'div',
-    classList: MEMBERS_ONLINE_CLASS_LIST,
+    classList: USERS_ONLINE_CLASS_LIST,
   });
 
-  const memberImage = createProfileImage(member?.picture?.publicId);
-  const usernameText = createTextNode(member.username);
+  const userImage = createProfileImage(user?.picture?.publicId);
+  const usernameText = createTextNode(user.username);
 
   const profileAndNameDiv = createElement({
     type: 'div',
     classList: PROFILE_NAME_CLASS_LIST,
   });
-  profileAndNameDiv.append(memberImage, usernameText);
+  profileAndNameDiv.append(userImage, usernameText);
 
-  memberDiv.append(profileAndNameDiv, memberOnlineDiv);
+  userDiv.append(profileAndNameDiv, userOnlineDiv);
 
-  return memberDiv;
+  return userDiv;
 }
 
 function createAnchorLinkNode(url, title) {
@@ -81,19 +81,19 @@ function createTaskNode(task) {
   return div;
 }
 
-function getMembersListContent(members, classList = []) {
+function getUsersListContent(users, classList = []) {
   const fragment = new DocumentFragment();
 
-  const membersList = Object.keys(members);
+  const usersList = Object.keys(users);
 
-  membersList.forEach((member) => {
+  usersList.forEach((user) => {
     const li = createElement({ type: 'li' });
-    li.append(createMemberNode(members[member]));
+    li.append(createUserNode(users[user]));
     fragment.append(li);
   });
 
-  const ul = createElement({ type: 'ul', classList: MEMBERS_UL_CLASS_LIST });
-  ul.id = MEMBERS_LIST_ID;
+  const ul = createElement({ type: 'ul', classList: USERS_UL_CLASS_LIST });
+  ul.id = USERS_LIST_ID;
   ul.appendChild(fragment);
 
   return ul;
@@ -137,12 +137,12 @@ function hideLoadingSpinner(selector) {
   }
 }
 
-async function generateMemberTaskData(username) {
+async function generateUserTaskData(username) {
   if (isTaskDataBeingFetched) {
     return;
   }
 
-  showLoadingSpinner(`#${TASKS_CONTAINER_ID}`);
+  showLoadingSpinner(`${TASKS_CONTAINER_ID}`);
 
   isTaskDataBeingFetched = true;
 
@@ -151,54 +151,54 @@ async function generateMemberTaskData(username) {
     tasksDiv.firstElementChild.remove();
   }
 
-  const memberTaskData = await getMemberTaskData(username);
+  const userTaskData = await getUserTaskData(username);
   isTaskDataBeingFetched = false;
   hideLoadingSpinner(`#${TASKS_CONTAINER_ID}`);
-  tasksDiv.appendChild(getTaskDataContent({ tasks: memberTaskData, username }));
+  tasksDiv.appendChild(getTaskDataContent({ tasks: userTaskData, username }));
 }
 
-async function generateMembersList() {
-  showLoadingSpinner(`#${MEMBERS_CONTAINER_ID}`);
-  members = await getMembersData();
-  hideLoadingSpinner(`#${MEMBERS_CONTAINER_ID}`);
-  const membersDiv = document.getElementById(MEMBERS_CONTAINER_ID);
+async function generateUsersList() {
+  showLoadingSpinner(`#${USERS_CONTAINER_ID}`);
+  let users = await getUsersData();
+  hideLoadingSpinner(`#${USERS_CONTAINER_ID}`);
+  const usersDiv = document.getElementById(USERS_CONTAINER_ID);
   const searchInputBox = generateSearchInputElement();
-  membersDiv.append(searchInputBox, getMembersListContent(members));
-  addEventListenerToMembersList();
+  usersDiv.append(searchInputBox, getUsersListContent(users));
+  addEventListenerToUsersList();
 }
 
-function addEventListenerToMembersList() {
-  const membersList = document.querySelector(`#${MEMBERS_CONTAINER_ID} > UL`);
-  membersList.addEventListener('click', (event) => {
-    const memberElement = event.target.closest(`.${MEMBERS_CLASS}`);
+function addEventListenerToUsersList() {
+  const usersList = document.querySelector(`#${USERS_CONTAINER_ID} > UL`);
+  usersList.addEventListener('click', (event) => {
+    const userElement = event.target.closest(`.${USERS_CLASS}`);
     document.getElementById(TASKS_CONTAINER_ID).style.display = 'block';
-    if (!memberElement) {
+    if (!userElement) {
       return;
     }
-    const username = memberElement.dataset.username;
+    const username = userElement.dataset.username;
     if (!username) {
       throw new Error('Some error occurred, please try again or contact admin');
     }
-    generateMemberTaskData(username);
+    generateUserTaskData(username);
   });
 }
 
 function generateSearchInputElement() {
   const searchInputField = createElement({
     type: 'input',
-    classList: MEMBERS_SEARCH_INPUT_CLASS_LIST,
+    classList: USERS_SEARCH_INPUT_CLASS_LIST,
   });
   searchInputField.type = 'text';
-  searchInputField.id = MEMBERS_SEARCH_ID;
+  searchInputField.id = USERS_SEARCH_ID;
   searchInputField.onkeyup = searchFunction;
-  searchInputField.placeholder = MEMBERS_SEARCH_PLACEHOLDER;
+  searchInputField.placeholder = USERS_SEARCH_PLACEHOLDER;
 
   const div = createElement({
     type: 'div',
-    classList: MEMBERS_SEARCH_CLASS_LIST,
+    classList: USERS_SEARCH_CLASS_LIST,
   });
   div.appendChild(searchInputField);
   return div;
 }
 
-generateMembersList();
+generateUsersList();
diff --git a/online-members/sse-events.js b/online-members/sse-events.js
index 933915ed..1627864a 100644
--- a/online-members/sse-events.js
+++ b/online-members/sse-events.js
@@ -5,7 +5,7 @@
 let currentOnlineList = [];
 let previousOnlineList = [];
 
-function setUpOnlineMembersEventSource(url) {
+function setUpOnlineUsersEventSource(url) {
   const eventSource = new EventSource(url, { withCredentials: true });
 
   eventSource.onopen = (e) => {
@@ -17,16 +17,16 @@ function setUpOnlineMembersEventSource(url) {
       const objectData = JSON.parse(event.data);
       currentOnlineList = objectData.users;
 
-      previousOnlineList.forEach((member) => {
-        members[member].isOnline = false;
+      previousOnlineList.forEach((user) => {
+        users[user].isOnline = false;
       });
 
-      currentOnlineList.forEach((member) => {
-        members[member].isOnline = true;
+      currentOnlineList.forEach((user) => {
+        users[user].isOnline = true;
       });
 
       previousOnlineList = currentOnlineList;
-      updateMembersOnlineStatus(currentOnlineList, members);
+      updateUsersOnlineStatus(currentOnlineList, users);
     } catch (error) {
       console.error(
         'Error occurred while processing data, please contact admin',
@@ -43,28 +43,27 @@ function setUpOnlineMembersEventSource(url) {
   return eventSource;
 }
 
-const onlineMembersEventSource =
-  setUpOnlineMembersEventSource(RDS_SSE_ONLINE_URL);
+const onlineUsersEventSource = setUpOnlineUsersEventSource(RDS_SSE_ONLINE_URL);
 
-function updateMembersOnlineStatus(onlineMembersList, members) {
+function updateUsersOnlineStatus(onlineUsersList, users) {
   let targetPositionOfOnlineMember = 0;
-  const membersUl = document.getElementById(MEMBERS_LIST_ID);
-  const memberLi = membersUl.getElementsByTagName('li');
-  // Hiding online status for all members
-  for (const member of memberLi) {
-    const memberDiv = member.getElementsByClassName(MEMBERS_CLASS)[0];
-    const memberUsername = memberDiv.dataset.username;
+  const usersUl = document.getElementById(USERS_LIST_ID);
+  const userLi = usersUl.getElementsByTagName('li');
+  // Hiding online status for all users
+  for (const user of userLi) {
+    const userDiv = user.getElementsByClassName(USERS_CLASS)[0];
+    const username = userDiv.dataset.username;
 
-    const memberOnlineStatusDiv =
-      member.getElementsByClassName(MEMBERS_ONLINE_CLASS)[0];
-    memberOnlineStatusDiv.classList.add(MEMBERS_ONLINE_HIDDEN_CLASS);
+    const userOnlineStatusDiv =
+      user.getElementsByClassName(USERS_ONLINE_CLASS)[0];
+    userOnlineStatusDiv.classList.add(USERS_ONLINE_HIDDEN_CLASS);
 
-    // Showing online status for online members
-    if (members[memberUsername].isOnline) {
-      memberOnlineStatusDiv.classList.remove(MEMBERS_ONLINE_HIDDEN_CLASS);
+    // Showing online status for online users
+    if (users[username].isOnline) {
+      userOnlineStatusDiv.classList.remove(USERS_ONLINE_HIDDEN_CLASS);
 
       // Moving online users to the top of list
-      membersUl.insertBefore(member, memberLi[targetPositionOfOnlineMember++]);
+      usersUl.insertBefore(user, userLi[targetPositionOfOnlineMember++]);
     }
   }
 }
diff --git a/online-members/utils.js b/online-members/utils.js
index c6fc98b4..2dc62f67 100644
--- a/online-members/utils.js
+++ b/online-members/utils.js
@@ -19,29 +19,29 @@ async function makeApiCall(
   }
 }
 
-async function getMembersData() {
-  let membersList = null;
-  const memberObject = {};
-  const membersRequest = await makeApiCall(RDS_API_MEMBERS);
-  if (membersRequest.status === 200) {
-    membersList = await membersRequest.json();
-    membersList = membersList.users;
-    membersList = membersList.filter((member) => !member.incompleteUserDetails);
-    membersList.forEach((member) => {
-      memberObject[`${member.username}`] = {
+async function getUsersData() {
+  let usersList = null;
+  const userObject = {};
+  const usersRequest = await makeApiCall(RDS_API_USERS);
+  if (usersRequest.status === 200) {
+    usersList = await usersRequest.json();
+    usersList = usersList.users;
+    usersList = usersList.filter((user) => !user.incompleteUserDetails);
+    usersList.forEach((user) => {
+      userObject[`${user.username}`] = {
         isOnline: false,
-        ...member,
+        ...user,
       };
     });
   }
-  return memberObject;
+  return userObject;
 }
 
-async function getMemberTaskData(username) {
+async function getUserTaskData(username) {
   let taskData = null;
-  const membersRequest = await makeApiCall(rdsApiTaskDetails(username));
-  if (membersRequest.status === 200) {
-    taskData = await membersRequest.json();
+  const usersRequest = await makeApiCall(rdsApiTaskDetails(username));
+  if (usersRequest.status === 200) {
+    taskData = await usersRequest.json();
     taskData = taskData.tasks;
   }
   return taskData;
@@ -55,7 +55,7 @@ const getCloudinaryImgURL = (publicId, configs) => {
   return `${RDS_CLOUDINARY_CLOUD_URL}${imageSizeOptions}/${publicId}`;
 };
 
-function getMemberProfileImageLink(publicId) {
+function getUserProfileImageLink(publicId) {
   return publicId
     ? getCloudinaryImgURL(publicId, RDS_PROFILE_IMAGE_SIZE)
     : RDS_PROFILE_DEFAULT_IMAGE;
@@ -63,9 +63,9 @@ function getMemberProfileImageLink(publicId) {
 
 function searchFunction() {
   let divText, txtValue;
-  const input = document.getElementById('search-members');
+  const input = document.getElementById('search-users');
   const filter = input.value.toUpperCase();
-  const ul = document.getElementById(MEMBERS_LIST_ID);
+  const ul = document.getElementById(USERS_LIST_ID);
   const li = ul.getElementsByTagName('li');
   const liArray = Array.from(li);
   liArray.forEach((liItem) => {
diff --git a/task/script.js b/task/script.js
index a85e0d8b..7101fca9 100644
--- a/task/script.js
+++ b/task/script.js
@@ -20,7 +20,7 @@ category.addEventListener('change', async () => {
     showSubmitLoader(false);
   }
 });
-let membersData = [];
+let usersData = [];
 
 const getRemainingDays = (selectedDateInString) => {
   const selectedDate = new Date(selectedDateInString);
@@ -439,7 +439,7 @@ async function fetchUsers() {
   try {
     const response = await fetch(`${API_BASE_URL}/users`);
     const data = await response.json();
-    membersData = data.users;
+    usersData = data.users;
   } catch {
     return;
   }
@@ -449,11 +449,11 @@ fetchTags();
 fetchLevel();
 fetchUsers();
 
-function filterMembers(searchInput) {
+function filterUsers(searchInput) {
   clearSuggestionList();
   wasAssigneeSet = false;
   if (searchInput.trim() !== '') {
-    const matches = membersData.filter((task) => {
+    const matches = usersData.filter((task) => {
       if (task.username) {
         clearUserNotFound();
         return task.username.toLowerCase().includes(searchInput.toLowerCase());
@@ -533,7 +533,7 @@ function createSuggestedUserLists() {
 
 assigneeEl.addEventListener(
   'input',
-  debounce((event) => filterMembers(event.target.value), 500),
+  debounce((event) => filterUsers(event.target.value), 500),
 );
 
 assigneeEl.addEventListener('click', createSuggestedUserLists);

From e281f4a99189c13614be48187473e7d15f7f601e Mon Sep 17 00:00:00 2001
From: kotesh-arya <koteswarraomudila@gmail.com>
Date: Wed, 11 Oct 2023 15:54:01 +0530
Subject: [PATCH 5/6] REFATOR: replaced initialisation with an array

---
 online-members/utils.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/online-members/utils.js b/online-members/utils.js
index 2dc62f67..8afdec91 100644
--- a/online-members/utils.js
+++ b/online-members/utils.js
@@ -20,7 +20,7 @@ async function makeApiCall(
 }
 
 async function getUsersData() {
-  let usersList = null;
+  let usersList = [];
   const userObject = {};
   const usersRequest = await makeApiCall(RDS_API_USERS);
   if (usersRequest.status === 200) {

From f4da15a11b56fd140aec7cb6b57e8b58dba687b6 Mon Sep 17 00:00:00 2001
From: kotesh-arya <koteswarraomudila@gmail.com>
Date: Wed, 11 Oct 2023 17:40:42 +0530
Subject: [PATCH 6/6] CHORES: prettier fix

---
 script.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/script.js b/script.js
index 56836d11..c3b19e2e 100644
--- a/script.js
+++ b/script.js
@@ -339,7 +339,6 @@ addClickEventListener(
   'POST',
 );
 
-
 const DROPDOWN_OPTIONS = [
   {
     name: 'Home',
@@ -439,7 +438,6 @@ async function handleUserSignin() {
 }
 handleUserSignin();
 
-
 addClickEventListener(
   syncIdle7dUsersButton,
   '/discord-actions/group-idle-7d',