From 00a81d4018e30414206db19e78449f71ed1c1ad7 Mon Sep 17 00:00:00 2001 From: AnujChhikara Date: Thu, 24 Oct 2024 10:40:03 +0530 Subject: [PATCH 1/2] Fix: Side panel data not updating when different user cards are clicked --- users/discord/App.js | 18 +++++++++--------- users/discord/components/UsersSection.js | 3 ++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/users/discord/App.js b/users/discord/App.js index 87fa873d..8514a852 100644 --- a/users/discord/App.js +++ b/users/discord/App.js @@ -37,16 +37,16 @@ const handleTabNavigation = async (e) => { } }; -const handleUserSelected = (e) => { - const selectedUserId = - e.target?.getAttribute('data_key') || - e.target.parentElement?.getAttribute('data_key'); - - if (selectedUserId) { - showUser = usersData[activeTab]?.findIndex( - (user) => user.id === selectedUserId, +const handleUserSelected = (userId) => { + if (userId) { + const selectedIndex = usersData[activeTab]?.findIndex( + (user) => user.id === userId, ); - rerender(App(), window['root']); + + if (selectedIndex !== -1) { + showUser = selectedIndex; + rerender(App(), window['root']); + } } }; diff --git a/users/discord/components/UsersSection.js b/users/discord/components/UsersSection.js index 4d0ac94b..51773f79 100644 --- a/users/discord/components/UsersSection.js +++ b/users/discord/components/UsersSection.js @@ -5,7 +5,7 @@ export const UsersSection = ({ users, showUser, handleUserSelected }) => { 'aside', { class: 'users_section', - onClick: handleUserSelected, + 'data-testid': 'users-section', }, users?.map((user) => { @@ -17,6 +17,7 @@ export const UsersSection = ({ users, showUser, handleUserSelected }) => { }`, 'data-testid': `user-card-${user.id}`, 'data-key': user.id, + onclick: () => handleUserSelected(user.id), }, [ createElement('img', { From 89e7f925996de1a3994fdadb57cf11b1bf40f8ea Mon Sep 17 00:00:00 2001 From: AnujChhikara Date: Thu, 24 Oct 2024 21:35:39 +0530 Subject: [PATCH 2/2] renamed the variable --- users/discord/App.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/users/discord/App.js b/users/discord/App.js index 8514a852..d1b57e0e 100644 --- a/users/discord/App.js +++ b/users/discord/App.js @@ -39,12 +39,12 @@ const handleTabNavigation = async (e) => { const handleUserSelected = (userId) => { if (userId) { - const selectedIndex = usersData[activeTab]?.findIndex( + const selectedUserIndex = usersData[activeTab]?.findIndex( (user) => user.id === userId, ); - if (selectedIndex !== -1) { - showUser = selectedIndex; + if (selectedUserIndex !== -1) { + showUser = selectedUserIndex; rerender(App(), window['root']); } }