From 9b694b2a4d6adc5df3f178e8a107c7c5b20ef961 Mon Sep 17 00:00:00 2001
From: shubhamsigdar1 <shubhamsigdar@gmail.com>
Date: Mon, 24 Jul 2023 12:42:07 +0530
Subject: [PATCH] remove repetitive  hbs file  code using loop

---
 app/components/new-signup/checkbox.hbs | 53 +++++++-------------------
 app/components/new-signup/checkbox.js  | 19 +++++++++
 2 files changed, 32 insertions(+), 40 deletions(-)

diff --git a/app/components/new-signup/checkbox.hbs b/app/components/new-signup/checkbox.hbs
index 958d4990..16430bff 100644
--- a/app/components/new-signup/checkbox.hbs
+++ b/app/components/new-signup/checkbox.hbs
@@ -2,47 +2,20 @@
   <h2 class='user-details__heading' data-test-signup-form-label>
     {{this.label}}
   </h2>
+
   <div class='role-details__field'>
-    <label class='checkbox-label'>
-      <input
-        type='checkbox'
-        name='developer'
-        checked={{false}}
-        {{on 'change' this.checkboxFieldChanged}}
-        class='checkbox-input'
-      />
-      Developer
-    </label>
-    <label class='checkbox-label'>
-      <input
-        type='checkbox'
-        name='designer'
-        checked={{false}}
-        {{on 'change' this.checkboxFieldChanged}}
-        class='checkbox-input'
-      />
-      Designer
-    </label>
-    <label class='checkbox-label'>
-      <input
-        type='checkbox'
-        name='mavens'
-        checked={{false}}
-        {{on 'change' this.checkboxFieldChanged}}
-        class='checkbox-input'
-      />
-      Mavens
-    </label>
-    <label class='checkbox-label'>
-      <input
-        type='checkbox'
-        name='productmanager'
-        checked={{false}}
-        {{on 'change' this.checkboxFieldChanged}}
-        class='checkbox-input'
-      />
-      Product Manager
-    </label>
+    {{#each this.checkboxData as |data|}}
+      <label class='checkbox-label'>
+        <input
+          type='checkbox'
+          name={{data.name}}
+          checked={{false}}
+          {{on 'change' this.checkboxFieldChanged}}
+          class='checkbox-input'
+        />
+        {{data.label}}
+      </label>
+    {{/each}}
   </div>
 
   <div class='signup-action__btn'>
diff --git a/app/components/new-signup/checkbox.js b/app/components/new-signup/checkbox.js
index 880d6bc0..4de0a4d1 100644
--- a/app/components/new-signup/checkbox.js
+++ b/app/components/new-signup/checkbox.js
@@ -3,6 +3,25 @@ import { action } from '@ember/object';
 import { LABEL_TEXT } from '../../constants/new-signup';
 
 export default class SignupComponent extends Component {
+  checkboxData = [
+    {
+      label: 'Developer',
+      name: 'developer',
+    },
+    {
+      label: 'Designer',
+      name: 'designer',
+    },
+    {
+      label: 'Mavens',
+      name: 'mavens',
+    },
+    {
+      label: 'Product Manager',
+      name: 'productmanager',
+    },
+  ];
+
   get label() {
     const { currentStep } = this.args;