Skip to content

Commit

Permalink
Clearer variable names
Browse files Browse the repository at this point in the history
  • Loading branch information
edmundedgar committed Nov 28, 2023
1 parent 0296ab4 commit 6186a5e
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions contracts/L1GlobalForkRequester.sol
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ contract L1GlobalForkRequester is MoneyBoxUser {

struct FailedForkRequest {
uint256 amount;
uint256 amountMigratedY;
uint256 amountMigratedN;
uint256 amountMigratedYes;
uint256 amountMigratedNo;
}
// Token => Beneficiary => ID => FailedForkRequest
mapping(address=>mapping(address=>mapping(bytes32=>FailedForkRequest))) public failedRequests;
Expand Down Expand Up @@ -113,8 +113,8 @@ contract L1GlobalForkRequester is MoneyBoxUser {
/*
// Probably need something like:
uint256 amountRemainingY = amount - failedRequests[token][requester][requestId].amountMigratedY;
uint256 amountRemainingN = amount - failedRequests[token][requester][requestId].amountMigratedN;
uint256 amountRemainingY = amount - failedRequests[token][requester][requestId].amountMigratedYes;
uint256 amountRemainingN = amount - failedRequests[token][requester][requestId].amountMigratedNo;
if (doYesToken) {
require(amountRemainingY > 0, "Nothing to migrate for Y");
Expand All @@ -123,8 +123,8 @@ contract L1GlobalForkRequester is MoneyBoxUser {
}
if (doNoToken) {
require(amountMigratedN > 0, "Nothing to migrate for N");
token.splitTokensIntoChildTokens(amountMigratedN, 0);
require(amountMigratedNo > 0, "Nothing to migrate for N");
token.splitTokensIntoChildTokens(amountMigratedNo, 0);
amountRemainingN = 0;
}
Expand Down

0 comments on commit 6186a5e

Please sign in to comment.