Deployment script for the contract #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundedgar
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Gonna approve this, I haven't looked deeply at the parts that look like they're copied over from the zkevm deployment. At some point we probably want to make sure we're maintaining the simplest diff we can from their code so we can merge in upstream changes, and maybe script copying it into our repo from theirs if we need to do that, but for now I think it makes sense to concentrate on getting our thing running.
|
replaced by: Deployment rebased on fork5 #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is quite big, because deployment is non-trivial and I am piggybacking on the deployment scripts from polygon which are in written using hardhat.
Hence, this PR contains:
(not yet all code is functional - I still have some raw copies)