Temp: 2nd guide react router v6 upgrade DO NOT MERGE #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this component accesses the history from v5, sets up a listener and then renders a "controlled" v6 <Router> This way both v5 and v6 APIs are talking to the same history instance
CompatRoute renders a v5 Route wrapped inside of a v6 context This makes both APIs available to the component tree inside of this route
+ Convert a use of useHistory to useLocation
There is an error about InsightsRoute:
Uncaught Error: [Redirect] is not a <Route> component. All component children of <Routes> must be a <Route> or <React.Fragment>
at Routes (webpack-internal:///./node_modules/react-router-dom-v5-compat/node_modules/react-router/dist/index.js:1248:5)
at InsightsRoutes (webpack-internal:///./src/InsightsRoutes.tsx:49:93)
This was the guide I was working with:
remix-run/react-router#8753
made it to just before this section: 6) Remove the compatibility package!
BUT the app did not work
(chore): Convert Switch to Routes of react-router
+ Convert CompatRoute to v6 Route
+ Convert Routes component name to InsightsRoutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.