-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heavy concurrency during hook creation causes erratic runtime behaviour #16
Comments
I never wrote That said, I can imagine at least two possible points of failure:
This is simply off the top of my head. I didn't look at the code much. Note: I'm currently on vacation and don't currently have access to a PC most of the time. I'll be home next weekend. |
Hi! We recently did a big refactor on our project that introduced parallel component/plugin loads, leading to a lot of hooks being created at the same time. This, on fast machines, seemingly leads to erratic runtime behaviour from reloaded-created hooks, such as:
Sadly, none of our devs are running into this, as it seemingly only happens to users on very fast machines, making it very hard to collect more details about the issue. We already placed a lock around Reloaded hook .ctors in order to have them succeed.
Switching to our MinHook-based backend that we have to troubleshoot issues like this, but don't use in production, resolves the issue. Disposing the misbehaving Reloaded hook, then recreating it at idle when no other hooks are being created, resolves the issue.
Is this a known problem/limitation? Is there anything we could do/log that could help with troubleshooting this?
Thanks!
The text was updated successfully, but these errors were encountered: