Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking issues on parallel builds #84

Open
flatmapthatshit opened this issue Aug 13, 2023 · 1 comment · May be fixed by #85
Open

Fix linking issues on parallel builds #84

flatmapthatshit opened this issue Aug 13, 2023 · 1 comment · May be fixed by #85

Comments

@flatmapthatshit
Copy link

While the Wiki often encourages parallel builds (e.g., with make -j4), tools/Makefile is not currently safe for parallel builds as it doesn't currently account for dependencies between programs.

E.g.:

  • tabledesign → audiofile
  • skyconv → n64graphics

More often than not, trying to compile tools with make -j4 will fail due to tabledesign finishing to compile before audiofile and then failing to link.

While this would ideally be solved by introducing separate rules per program accounting for dependencies, for now I'm forcing j1 for tools.

This fix was already merged upstream as part of PR sm64pc#512

flatmapthatshit added a commit to flatmapthatshit/Render96ex_macOS that referenced this issue Aug 13, 2023
@flatmapthatshit flatmapthatshit linked a pull request Aug 13, 2023 that will close this issue
flatmapthatshit added a commit to flatmapthatshit/Render96ex_macOS that referenced this issue Aug 13, 2023
@flatmapthatshit
Copy link
Author

@AndratVA has already backported this fix to branch tester_rt64alpha (97fc00e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant