forked from sm64pc/sm64ex
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linking issues on parallel builds #84
Comments
flatmapthatshit
added a commit
to flatmapthatshit/Render96ex_macOS
that referenced
this issue
Aug 13, 2023
flatmapthatshit
added a commit
to flatmapthatshit/Render96ex_macOS
that referenced
this issue
Aug 13, 2023
This was referenced Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While the Wiki often encourages parallel builds (e.g., with
make -j4
),tools/Makefile
is not currently safe for parallel builds as it doesn't currently account for dependencies between programs.E.g.:
More often than not, trying to compile tools with
make -j4
will fail due totabledesign
finishing to compile beforeaudiofile
and then failing to link.While this would ideally be solved by introducing separate rules per program accounting for dependencies, for now I'm forcing
j1
for tools.This fix was already merged upstream as part of PR sm64pc#512
The text was updated successfully, but these errors were encountered: