Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exclude domains from dead link checks #1316

Open
martukas opened this issue Oct 28, 2022 · 0 comments
Open

Do not exclude domains from dead link checks #1316

martukas opened this issue Oct 28, 2022 · 0 comments
Labels
Devops/CI Integration / testing / deployment Documentation Improvements or additions to documentation Software Umbrella: GUI, Controller or CI
Milestone

Comments

@martukas
Copy link
Member

martukas commented Oct 28, 2022

Documentation dead link checks should not exclude any domains.

How do you know it has to be done
Some of the links in our documentation may not lead to valid sites or pages. And we would not know this unless we checked them all manually. This is the one sub-task in #1313 that could not be satisfied. There are a dozen domains that are excluded from the documentation link checks. This is because those sites appear to block crawlers.

Starting points
Not sure of the mechanism or criteria for this blocking, but it maybe that it can detect the HTTP requests coming from CircleCI or Github servers. If we set up our own Jenkins CI on our own server (#1309 ), we may not be beholden to the same restrictions.

@martukas martukas added Documentation Improvements or additions to documentation Devops/CI Integration / testing / deployment Software Umbrella: GUI, Controller or CI labels Oct 28, 2022
@martukas martukas added this to the Goalpost v0.5 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devops/CI Integration / testing / deployment Documentation Improvements or additions to documentation Software Umbrella: GUI, Controller or CI
Projects
None yet
Development

No branches or pull requests

1 participant