-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
showManageSubscriptions
and beginRefundRequest
: swiftUI view modifiers
#1073
Comments
Love it! I'd like to do it if it's still available :) |
I imagine we will grow SwiftUI extensions a lot over time. We might want to offer them separately eventually, or maybe now? |
🤔 Good point. My two cents. Maybe not now, but as you said, there could be another UI related framework to isolate the Core layer from the UI. |
Yeah, I think it'd be nice and easy to set up as a separate pod and swift package. |
Hey 👋 I spotted the thread when I was looking here and there. It has the |
Hey @Zaprogramiacz! 👋 You are absolutely welcome to contribute to this! We're more than happy to review and to assist with any questions you have along the way 💪 |
Oh great 💪🏻 Do you have any documentation, task with AC or desired dreamed solution? I don't have an access to the link from the first post and I bet that I might find there useful info. In the thread I saw that last idea was to setup a separate pod and swift package with SwiftUI extensions. Is it still the main idea that should be followed? |
Hey, sorry for the late reply. Yeah, that's still the main idea, to have a separate SPM package and maybe also a pod, with just the SwiftUI extensions |
I think this issue already resolved in https://github.com/RevenueCat/purchases-ios/blame/main/Sources/Support/ManageSubscriptionsHelper.swift#L34 |
For SwiftUI apps, we should provide view modifiers to make it easy to use
showManageSubscriptions
andbeginRefundRequest
.We can use
#if canImport(SwiftUI)
to only declare these when SwiftUI types are available.For reference, here are the view modifiers declared by StoreKit.
https://app.shortcut.com/revenuecat/story/11882/showmanagesubscriptions-and-beginrefundrequest-swiftui-view-modifiers
The text was updated successfully, but these errors were encountered: