purchaseSubscriptionOption uses incorrect/old UpgradeInfo.oldSKU field and fails to upgrade Android subscription

[Markario]

• I have updated Purchases SDK to the latest version
• I have read the Contribution Guidelines
• I have searched the Community
• I have read docs.revenuecat.com
• I have searched for existing Github issues

Describe the bug
Calling purchaseSubscriptionOption with a GoogleProductChangeInfo argument fails to upgrade a subscription (adds a new subscription instead). The issue is that the implementation in the Android RNPurchasesModule uses the oldSKU field from the old UpgradeInfo instead of the typed oldProductIdentifier in GoogleProductChangeInfo. As a workaround I added oldSKU to the googleProductChangeInfo argument as well.

• purchaseSubscriptionOption implementation that checks for oldSKU instead of oldProductIdentifier
  

  react-native-purchases/android/src/main/java/com/revenuecat/purchases/react/RNPurchasesModule.java

  Lines 209 to 216 in 93ef699

  	public void purchaseSubscriptionOption(final String productIdentifer,
  	final String optionIdentifier,
  	@Nullable final ReadableMap upgradeInfo,
  	@Nullable final String discountTimestamp,
  	@Nullable final ReadableMap googleInfo,
  	@Nullable final String presentedOfferingIdentifier,
  	final Promise promise) {
  	String googleOldProductId = upgradeInfo != null && upgradeInfo.hasKey("oldSKU") ? upgradeInfo.getString("oldSKU") : null;

• purchaseSubscriptionOption typed with GoogleProductChangeInfo
  

  react-native-purchases/src/purchases.ts

  Lines 476 to 480 in 93ef699

  	public static async purchaseSubscriptionOption(
  	subscriptionOption: SubscriptionOption,
  	googleProductChangeInfo?: GoogleProductChangeInfo,
  	googleIsPersonalizedPrice?: boolean,
  	): Promise<MakePurchaseResult> {

Same issue in the community https://community.revenuecat.com/sdks-51/reactnative-sdk-purchasesubscriptionoption-not-applying-proration-and-oldproductidentifier-3520

1. Environment
   1. Platform: Android
   2. SDK version: 7.2.0
   3. OS version:
   4. Xcode/Android Studio version:
   5. React Native version:
   6. SDK installation (CocoaPods + version or manual):
   7. How widespread is the issue. Percentage of devices affected.
2. Debug logs that reproduce the issue
3. Steps to reproduce, with a description of expected vs. actual behavior
4. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)

Additional context
Add any other context about the problem here.

[RCGitBot]

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

[tonidero]

Thanks for reporting and debugging @Markario. You're correct, that method is incorrectly parsing the old product identifier. We will release a fix for this issue soon.

[ColeTownsend]

Also found this issue to break our android upgrade flow

[tonidero]

Sorry we forgot to update the issue here. A fix for this was released in 7.3.0. Please let us know if that solved your issue @Markario.

@ColeTownsend could you confirm what version you're using to confirm it's not the same error?

[ColeTownsend]

We are using 7.5.1, we had to change what values we were sending in the makePurchase function to include the new GoogleProductChange value in addition to the deprecated UpgradeInfo.

Wasn't sure if this was fixed/closed