-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android v4 to v5 NativeModules argument mismatch – Required Google Play upgrade #795
Comments
👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out! |
Hi @masiamj, thanks for reaching out! First of all, you will need to upgrade at least to version 6.x in order to get the BC5 update, as mentioned here. We have a migration guide for that version here. But we do recommend updating to v7 if possible to get one more year of support from Google, since changes from v6 to v7 at the API level should be minimal. As for your issue, I was checking the code and we're passing 6 parameters for that method: https://github.com/RevenueCat/react-native-purchases/blob/5.16.0/src/purchases.ts#L287. A couple of questions:
|
Hi @tonidero thanks for your quick response, without upgrading fully to v6, here's an update to your questions: Per the
I have tried wiping Any other thoughts or information I can provide to help? Thanks! |
Hi @masiamj, one more question, does this happen for iOS as well?
|
Hi @tonidero this behavior is not happening on iOS as well. I've tried your other suggestion and unfortunately none have worked. I'll keep working on it and hopefully will respond with an answer. |
hey team, any update for this? We are blocked from using RevenueCat as our purchase system because Google doesn't like Play Billing Library 4.0 any more. is there any temporary workaround while we wait for the update? |
Also facing the same is from Google Play Billing needing Library 4.0 or greater |
Hi! Sorry for missing this issue @KenRiku and @mjubilee1, our latest React Native SDK uses Billing client 6. What version are you trying to use? Also, that issue seems unrelated to this one. Please open a different ticket if you still have issues after updating to the latest version! 🙏 @masiamj @chandchawla324 Really sorry for the delay. I gave it another try and I was still not able to reproduce... Could you provide a minimum reproducible project where this issue happens? It still seems as if it's using an outdated version somewhere. |
Describe the bug
Hi all, first-off thanks for your awesome library. I love this package and the RevenueCat ecosystem.
Unfortunately, upon submitting a new version of my app to the Play Store this week I was met with an error that the Google Play Store billing API version has been deprecated and must be upgraded before submitting a new version. Admittedly, my team is way out of date here.
As such, I would like to perform an upgrade from
react-native-purchases@4
toreact-native-purchases@5
which should be mostly backward compatible (without changing the structure of our subscription packages).I spent time reviewing the changelog and decided to upgrade to v5.16.0 and followed the guide here: https://github.com/RevenueCat/react-native-purchases/blob/main/v4_to_v5_migration_guide.md.
For the most part this was extremely smooth and the naming convention changes and configuration API changes make sense and are very reasonable.
I was then able to bundle the aab; however, upon testing my app, I'm receiving crashes due to a native module argument mismatch. See the error here:
I reviewed the package code and native code being called and it appears that everything should be fine. The logcat message is correct that the native module requires 6 arguments and I can confirm that the JS layer does pass all the required arguments.
So now, I'm just a little stuck and would love any help/input/insights your team or the community may have. This is a blocker for me releasing the next version of our app.
Thanks so much!
Runtime version: 17.0.6+0-17.0.6b829.9-10027231 aarch64
Additional context
It looks like others are having this issue as well but was previously closed due to inactivity: #159.
The text was updated successfully, but these errors were encountered: