Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CPFP fee bumping flow by integrating mempool.space api #1255

Closed
saubyk opened this issue Jun 9, 2023 · 1 comment · Fixed by #1386
Closed

Simplify CPFP fee bumping flow by integrating mempool.space api #1255

saubyk opened this issue Jun 9, 2023 · 1 comment · Fixed by #1386
Labels
Core Lightning CPFP enhancement New feature or request LND medium mempoolspace Issues related to mempool.space integration
Milestone

Comments

@saubyk
Copy link
Collaborator

saubyk commented Jun 9, 2023

CPFP process to bump up pending channel opens can be simplified by using mempool.space API to query the transaction and bump up the fee, without user having to determine what's their change output index.

With the API, additional validations can also be made to ensure that user has sufficient funds in the change output, to be able to bump up the channel opening transaction

API: https://mempool.space/docs/api/rest#get-transaction

EDIT:

  1. Remove the information text from the modal and instead display the current fee rates from the mempool api
  2. Output Index form value on the modal shouldn't be greyed out, so that user can modify it if needed
  3. Add a warning for the user if the change output has a balance lower than 1000 sats: Change output balance may be insufficient for fee bumping, depending on the prevailing fee rates
@saubyk saubyk changed the title Simply CPFP fee bumping flow by integrating mempool.space api Simplify CPFP fee bumping flow by integrating mempool.space api Oct 11, 2023
@saubyk saubyk added the mempoolspace Issues related to mempool.space integration label Oct 11, 2023
@saubyk saubyk added this to the Release 0.15.0-beta milestone Oct 11, 2023
@ShahanaFarooqui ShahanaFarooqui linked a pull request May 10, 2024 that will close this issue
@ShahanaFarooqui
Copy link
Collaborator

Closing with PR #1386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Lightning CPFP enhancement New feature or request LND medium mempoolspace Issues related to mempool.space integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants