Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

列名がNAの列の強制除去をやめ,オプションにする #129

Open
Rindrics opened this issue Jul 5, 2019 · 7 comments
Open
Labels

Comments

@Rindrics
Copy link
Owner

Rindrics commented Jul 5, 2019

image

B列はクラスタ抽出に使っているから残るが,C:Gがごっそりなくなる
@Rindrics
Copy link
Owner Author

Rindrics commented Jul 5, 2019

@Rindrics
Copy link
Owner Author

Rindrics commented Jul 5, 2019

@Rindrics
Copy link
Owner Author

Rindrics commented Jul 5, 2019

  • rebel(..., rm_nacols = list(except = 1:3)) <- むやみに引数を増やすのは慎むべき
  • rm_nacols(df, except = NULL)

@Rindrics
Copy link
Owner Author

Rindrics commented Jul 5, 2019

対策

今は,複数列に渡る行ヘッダが消えているから困っている.

どうやって使うと,コーディングしやすいか

  1. rebel(fname, sheet_regex = ".+") ここでは,NA行は削除されないべき.
  2. rebel(fname, sheet_regex = ".+", row_merged = ) しないと,クラスタ抽出時に情報がなくなる セル結合 #17 (comment)
  3. rebel(fname, sheet_regex = ".+", row_merged = , unclusterize = )
    までで一通り矩形になるはず

What should I do

row|col_merged = NULL の状況下では rm_nacols() を発動させてはいけない

@Rindrics Rindrics added the UI label Jul 26, 2019
@Rindrics
Copy link
Owner Author

本パッケージは「データを矩形に読み込む」ことに特化するため、
rm_nacolsは廃止する方向となった

@Rindrics
Copy link
Owner Author

Rindrics commented Mar 7, 2020

廃止してしまうと依存パッケージの挙動が変わるので、「左上隅だけはNAでも除去しない」とする

@Rindrics
Copy link
Owner Author

Rindrics commented Mar 7, 2020

https://github.com/JK-junkin/stockdbr/pull/171rm_nacolsのせいではなさそう。調査継続

@Rindrics Rindrics added this to ICEBOX in Sprint Board Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Sprint Board
  
ICEBOX
Development

No branches or pull requests

1 participant