Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather_cols()をdeprecatedにする #204

Open
Rindrics opened this issue Apr 8, 2020 · 2 comments
Open

gather_cols()をdeprecatedにする #204

Rindrics opened this issue Apr 8, 2020 · 2 comments

Comments

@Rindrics
Copy link
Owner

Rindrics commented Apr 8, 2020

stockdbrで呼ばれているのでdeprecated()する

.Deprecated(pivot_longer, package=tidyr, msg,
            old = as.character(sys.call(sys.parent()))[1L])

ver1.0.9000で廃止予定

@Rindrics Rindrics added this to PRODUCT BACKLOG in Sprint Board Apr 16, 2020
@Rindrics Rindrics moved this from PRODUCT BACKLOG to SPRINT BACKLOG in Sprint Board Apr 16, 2020
@akimanabe
Copy link
Collaborator

Deprecateして、代わりに pivot_cols でも新設しますか?
むしろ、0.2.0.9000 ➡️ 0.3.0.9000 にして、gather_colsの中身を tidyr::gather から tidyr::pivot_longer に変えるだけじゃダメですかね。

gather_cols の中で必要な引数をちゃんと pivot 版に合致するように設定すれば rebel(cluster) の仕様は変更しないで済むし。

@Rindrics
Copy link
Owner Author

むしろ、0.2.0.9000 ➡️ 0.3.0.9000 にして、gather_colsの中身を tidyr::gather から tidyr::pivot_longer に変えるだけじゃダメですかね。

ありがとう、そうします!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Sprint Board
  
SPRINT BACKLOG
Development

No branches or pull requests

2 participants