Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named step collections #263

Open
knownasilya opened this issue Oct 17, 2018 · 3 comments
Open

Named step collections #263

knownasilya opened this issue Oct 17, 2018 · 3 comments

Comments

@knownasilya
Copy link

knownasilya commented Oct 17, 2018

Currently I have multiple lists of steps depending on routes and the state of the app or the permissions of the user.

I extend the tour service to make this possible by changing the steps in a modified start method.

I'd love to see something like:

tourService.addSteps('default', steps);
tourService.addSteps('default-loggedin', loggedInSteps);

Somewhere else:

let modifier = isAuthenticated ? '-loggedin' : '';

tourService.start(`default${modifier}`);
@RobbieTheWagner
Copy link
Owner

@knownasilya would this not work better as separate tours, rather than switching steps for one tour?

@knownasilya
Copy link
Author

Well, you can only have one tour open at a time. If there was multiple you have to handle the state of closing a currently open tour before opening a new one on a different service. But, aside from that, multiple services might work.

@RobbieTheWagner
Copy link
Owner

We should definitely build in multiple tour support to ember-shepherd. This is something you could do with Shepherd OOTB, so we should support it here. @BrianSipple @chuckcarpenter any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants