Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test helpers #266

Open
BrianSipple opened this issue Oct 27, 2018 · 2 comments
Open

Add test helpers #266

BrianSipple opened this issue Oct 27, 2018 · 2 comments
Assignees

Comments

@BrianSipple
Copy link
Contributor

BrianSipple commented Oct 27, 2018

Ongoing idea list:

  • assertCurrentTour(assert, tourName) {}
  • assertTourActive(assert, message = 'tour is active) {}
  • assertTourInactive(assert, message = 'no tour is active') {}
  • assertTourStep(assert, stepName) {}
  • assertTourStepHidden(assert, message = 'tour is active but current step is not shown') {}
  • assertTourStepVisible(assert, message = 'tour is active and current step is shown') {}
@grapho
Copy link

grapho commented Mar 20, 2020

I support this idea, though perhaps exposing Shepherd's modalContainer would allow tours to render inside of the actual app and therefore could be tested in acceptance tests and possibly allow for visual regression tests (Percy)

@RobbieTheWagner
Copy link
Owner

@grapho I responded to this in the other issue, but responding here as well. All Shepherd options can be used in ember-shepherd, without the need to expose extra things. You would have to pass these options as part of your tour/steps config, like the other options.

Also, Ember's test helpers take a parent element, so you are not limited to the Ember testing container, and you can still write tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants