Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 2 integration tests #746

Open
EzraBrooks opened this issue Jun 28, 2024 · 6 comments
Open

Add ROS 2 integration tests #746

EzraBrooks opened this issue Jun 28, 2024 · 6 comments

Comments

@EzraBrooks
Copy link
Contributor

We'd like to release roslibjs v2 with a lot of improvements (asynchronous Services, ROS 2 Actions, ROS 2 TFClient), but we don't yet have any integration tests in CI for the ROS 2 support. Once this is done, we can release v2!

@EzraBrooks EzraBrooks mentioned this issue Jun 28, 2024
@EzraBrooks EzraBrooks added this to the 2.0.0 milestone Jun 28, 2024
@sauk2
Copy link

sauk2 commented Jun 29, 2024

What do you think about using setup-ros instead of the current approach followed for ROS 1?

@EzraBrooks
Copy link
Contributor Author

EzraBrooks commented Jul 1, 2024

That makes sense to me. I figure we'll eventually remove the ROS 1 jobs once ROS 1 is deprecated, so we don't need to create a CI matrix that covers both ROS 1 and ROS 2 - they can be separate jobs with separate implementations.

@ganatrask
Copy link

Hey @EzraBrooks I'd like to work on this issue can you share more details on what things need to be added for tests or CI for ROS?

@EzraBrooks
Copy link
Contributor Author

The bulk of the work is to add ROS 2 versions of test/build.bash and .github/workflows/main.yml.

@labbomb
Copy link

labbomb commented Dec 17, 2024

It's been going on for a while, and now it's stuck? When will this milestone be released

@EzraBrooks
Copy link
Contributor Author

As you can see from the milestone, this is the last remaining issue. Feel free to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants