You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A small change in a fork of the repo helped me get 0 allocations in ROS2ForUnity dependent code.
It could go upto 0.9 KBs per class per frame which was very high. (Unity Profiler)
I haven't looked much inside the codebase but I assume there is some sort of error message stack in the C side that gets
converted to C# string. If I am correct the message needs to be popped otherwise it won't be coherent.
So, this change shouldn't cause any issues? 🤔
Am I correct in my assessment?
The text was updated successfully, but these errors were encountered:
Thank you for this great project.
I see that there is an error string that is being created even when we have
RCL_RET_OK
at:ros2cs/src/ros2cs/ros2cs_core/utils/Utils.cs
Line 48 in 6a42031
A small change in a fork of the repo helped me get 0 allocations in ROS2ForUnity dependent code.
It could go upto 0.9 KBs per class per frame which was very high. (Unity Profiler)
The change looks like this:
I haven't looked much inside the codebase but I assume there is some sort of error message stack in the C side that gets
converted to C# string. If I am correct the message needs to be popped otherwise it won't be coherent.
So, this change shouldn't cause any issues? 🤔
Am I correct in my assessment?
The text was updated successfully, but these errors were encountered: