-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.x #51
Comments
So far my approach with FOF has been to just fix compatibility issues when I use it with newer PHP versions. If it works, it's fine with me. The code won't win awards for elegance, and neither does it have to ;) |
It looks like PHP 8.3 has broken this again, which is, of course, super annoying. Thanks PHP, your API migration strategy is a nightmare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running FoF with PHP 8.0 or 8.1 shows a lot of Deprecation warnings and one Fatal Error in the PDO Log class. It inherits the PDO class but the function signatures and return types don't match.
The fatal error can be avoided by changing the query function signature to this.
public function query($query, $fetchMode = null, ...$fetchModeArgs)
But before I march ahead I wanted to discuss if I should just "bend" the code to make the warnings go away or if you have better ideas for a refactoring.
The text was updated successfully, but these errors were encountered: