Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #10

Open
RopoMen opened this issue Sep 1, 2015 · 0 comments
Open

Unit testing #10

RopoMen opened this issue Sep 1, 2015 · 0 comments

Comments

@RopoMen
Copy link
Owner

RopoMen commented Sep 1, 2015

  1. Add Karma coverage
  2. Test all parts of the module, including configuration (provider)
  3. Remove tests which are only testing LoDash methods, why we should test those? (LoDash has its own tests)
  4. Add only coupleof tests which ensure that parameters are passed correctly to the LoDash methods.
  5. Check if AngularJS has some other buildin filters which should be wrapped + check that current wrappers (min,max) are relevant.
  6. Check that ngFilterSpec.js is testing those wrapped filters also and those tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant