Change pub(crate) methods in kernel::error to be pub

[Darksonn]

Change the following methods from pub(crate) to pub:

• from_result
• from_err_ptr
• to_ptr

These methods will most likely be used from outside of the kernel crate, so using the pub marker is the correct way to mark them. Furthermore, using the pub marker instead of pub(crate) has the advantage that it doesn't produce dead-code warnings, avoiding the need for #[allow] and TODO annotations:

linux/rust/kernel/error.rs

Lines 271 to 273 in e26fa54

	// TODO: Remove `dead_code` marker once an in-kernel client is available.
	#[allow(dead_code)]
	pub(crate) fn from_err_ptr<T>(ptr: *mut T) -> Result<*mut T> {

One could argue that these methods shouldn't be used outside of the kernel crate because that means that someone is writing an abstraction directly in their driver. However, there are reasons to do that in some cases, so we cannot apply that rule so strictly that we can make these methods pub(crate). (And if we did apply that rule that strictly, then to_result should be changed to be pub(crate).)

We could make this change later when the methods gain a user outside of rust/kernel directory. However, I propose changing it now because:

1. Removing #[allow] and TODO annotations from error.rs simplifies it, making the code easier to read.
2. This will reduce clutter in any future patches that use the methods outside of the kernel crate.

I don't know whether all three methods will gain a user outside of the rust/kernel directory, but I expect that from_err_ptr will. However, I don't think there's any harm in changing all of them for consistency. After all, a pub marker is not incorrect for something only used in rust/kernel if we don't need to prevent users outside of rust/kernel from using it.

[felipeagger]

Hi, I made these adjusts and submitted the Patch, can you check please? Thank you.

Link ML

@Darksonn @ojeda

[ojeda]

Applied to rust-next -- thanks!