Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add danger-swiftlint (with Peril) #142

Open
freak4pc opened this issue Feb 22, 2018 · 0 comments
Open

Add danger-swiftlint (with Peril) #142

freak4pc opened this issue Feb 22, 2018 · 0 comments
Assignees

Comments

@freak4pc
Copy link
Member

Adding this here and self-assigning so I don't forget:

We have Swiftlint running successfully with no issues on CI, the problem is - it doesn't actually do anything with warnings. Only full failures will cause the CI to fail.

Since we already have Peril running cross-org, we can just add a Dangerfile with danger-swiftlint to comment everything needed on the PR itself.

@freak4pc freak4pc self-assigned this Feb 22, 2018
@M0rtyMerr M0rtyMerr self-assigned this Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants