-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile experience #217
Comments
Thank you for fixing this so quickly! The annotation pop up now comes up with a short tap on an annotation written to the pdf, but I cannot activate the context menu any more. Both the PDF++ custom menu and the new "show context menu on tablet devices" are enabled, but only the default obsidian menu comes up after selection. Also the color of a highlight is not saved to the pdf on mobile. The annotation is saved, copying, pasting, linking etc. works, but the color is not saved to the pdf - the color shows up correctly in a callout in the markdown file, if pasted. The screen recording shows both things: Screen_Recording_20240609_174804_Obsidian.mp4 |
@tprotopopescu Thank you for the detailed response! What kind of device are you on? It looks like an Android smartphone, not a tablet (like iPad). I will assume so in the following, but correct me if I'm wrong.
This is an intended change. From 0.40.5, tapping on the OS-default "Copy" menu will execute the PDF++ command "Copy link to selection or annotation", and this function is supposed to replace the role of the context menu.
As in the description under the "Context menu in PDF viewer" header, now the context menu is shown only on desktop & tablet. And "tablet" does not include smartphones (I'm sorry if it was not clear). It would be better if we had some means to open the context menu on smartphones as well, but so far, I have not figured it out. (Maybe I can add a new icon in the toolbar for context menu?)
Hmm. it looks weird. Did you tap on the color palette or the "Copy" menu? Also, could you provide the following information so that I can look into the issue?
|
I apologise, that was my misunderstanding I just jumped in and started trying things out! Yes, you are right, this is on an Android phone. I see how it works now. For the color I tapped on the color palette, on the button for green. This is only happening on one device (samsung galaxy note 20 ultra) but the color shows up as expected on a tablet (lenovo m8). Here is a file that this happens with: Unannotated: Blackburn and van Benthem - Modal Logic, a Semantic Perspective.pdf With annotation, the first two paragraphs should be highlighted: Blackburn and van Benthem - Modal Logic, a Semantic PerspectiveAnnotated.pdf Here is the debug info (sorry the code block is not preserving the indentation, I figure it is easier to read like this): { |
While testing out the color annotations I have noticed some more weirdness with writing to pdf on mobile. In most cases the file size shrinks. However I tried out one file that went from 37.8mb to 1.4gb! This happens on both my mobile devices, but not on desktop. Initially the file is 37.8mb, I write an annotation to the pdf file, and the file size starts to increase and over the next couple of minutes it grows to 1.4gb, the pdf reader is unresponsive while this is happening. If I add another annotation, or delete the one I did before, the file size drops to 370mb and then grows again to 1.4gb over the next few minutes. This seems to happen with large files (the file attached above #217 (comment) actually shrank, from 35kb to 25kb). Here is a link to the original file: File And here is a link to the expanded file: Expanded File |
I have been trying out the context menu on a tablet, and on my device I am getting two context menus popping up, one after selecting the first word which remains on screen, and then another when finishing the selection: screen-20240612-112124.mp4 |
In Ipad I can highlight papers, I can take create a square with a copied link but I cant highlight. RPReplay_Final1718312200.-.COMPRESS.mp4 |
@tprotopopescu Thank you again for the detailed reply! I will look into the issues. Much appreciated. |
@SSamDav
PDF++ is built on top of Obsidian's native PDF viewer, so I think it's Obsidian or PDF.js (the library behind the native viewer) that has to be improved. |
@RyotaUshio sorry I meant I can't highlight the text 😅, so I must be honest I really dont know how highlight should work, I expected that when I select a color and then select a piece of text the text is highlighted but that doesn't work neither on desktop neither on mobile. If i first select the text and then select the color it highlight on desktop but not on ipad. |
For what it is worth, regarding file size changing when writing to pdf (#217 (comment)) I tried a few more files. It seems to happen pretty reliably with books (200+ pages) bigger than 5mb, files smaller than that, having either fewer pages or smaller in size, tend to shrink in size. |
@SSamDav This might help (https://forum.obsidian.md/t/selecting-text-in-pdf-android-client-is-broken/81278/6) with the stylus selection, and selection in general. It seems that pdf.js, and/or obsidian's implementation of it, does not do well with selecting text when the zoom level is not one of the defaults. When I zoom in, more than 'fit to width' and try to select the selection area jumps around randomly. Going back to 'fit to width' makes selecting text better. I hope this gets fixed soon since it makes reading some pdfs on a phone in portrait mode almost impossible. |
@tprotopopescu Thanks for the information! But my problem is not in the selection part is more on trying to highlight the selected text 😂 |
in ipad ,it can't be loaded |
@1222A I can't reproduce it. I can install it both on my iPhone & iPad without any problem. Check your internet connection, ensure your iPadOS and Obsidian are up-to-date, and retry in the sandbox vault. If the problem persists, feel free to open a bug report following the template. |
@SSamDav If you haven't, check out the docs. |
I have no idea what could be behind this but immediately when I enable the plugin on my iPad, I can no longer scroll in Obsidian with the trackpad on my Magic Keyboard. I am on the public beta of iPadOS 17.6, so I’ll try rolling back to the last main release OS version before I open a bug report |
I am experiencing this issue on iPadOS 17.5.1 as well. Edit: Although enabling PDF++ causes this issue everywhere in my vault, there seems to be a problem with the Obsidian PDF viewer in general as I cannot use the Magic Keyboard touchpad or a mouse to scroll any PDFs that I’ve opened in Obsidian. |
Is anyone else finding text selection on mobile does not work very well (the selection jumps around, is extremely sensitive etc.)? This is an obsidian issue, not a pdf++ one, but if you are finding this please consider adding to this bug report on the obsidian forum (https://forum.obsidian.md/t/selecting-in-pdf-is-very-buggy-and-sporadic-in-windows-surface/84491/2) . |
Hi, I hope y'all enjoying this plugin.
This plugin was original created primarily for the desktop app, and therefore its mobile support has been incomplete.
However, recently I got a necessary environment for mobile debugging, and am planning to squash the mobile-specific bugs and unnatural behaviors.
I'd love to hear your opinion - feel free to report any weirdness you experienced on mobile. I personally don't use Obsidian on mobile devices extensively, so your feedback will be greatly appreciated.
The following issues is already known, and
will be fixed in the next releasehave already been fixed in 0.40.5:The text was updated successfully, but these errors were encountered: