Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sprites are missing in Mario Maker 2 on latest branch MacOS [Bug] #4506

Closed
jneen opened this issue Mar 3, 2023 · 9 comments · Fixed by #5551
Closed

Some sprites are missing in Mario Maker 2 on latest branch MacOS [Bug] #4506

jneen opened this issue Mar 3, 2023 · 9 comments · Fixed by #5551
Labels
bug Something isn't working gpu Related to Ryujinx.Graphics os:macOS An issue or feature request exclusively relating to macOS

Comments

@jneen
Copy link

jneen commented Mar 3, 2023

Description of the issue

image

It appears that any element from the tiles spritesheet is not displayed. Other sprite sheets seem to display fine, like enemies and items. Note that the starting ground is missing - I've also added ground, several blocks, and a conveyor, but they do not display (or display as entirely transparent).

Reproduction steps

  • Build Ryujinx on current master (tested on ecee34a)
  • Run Super Mario Maker 2
  • Make a course in any style other than 3DWorld
  • Note that the starting ground is missing, but still appears to have physics
  • Place any block tile, conveyor, semisolid, bridge, etc and note that they do not render.
  • Note that they do not render in play mode either.

Log file

ryujinx.log

I couldn't find the Logs folder so I tee'd the console output for a session where I loaded mario maker 2, and the bug was present on screen.

OS

MacOS (M1 Max) Ventura 13.2.1 (22D68)

Ryujinx version

master (ecee34a)

Game version

3.0.2

CPU

Apple M1 Max

GPU

Apple M1 Max

RAM

64GB

List of applied mods

Additional context?

No response

@jneen jneen added the bug Something isn't working label Mar 3, 2023
@jneen
Copy link
Author

jneen commented Mar 3, 2023

Seems to work fine on non-macos. Also the release macos version I have (1.1.0-macos1) seems to be fine. I'm not sure what branch or commit that's on but I'm happy to bisect it if need be.

[Screenshot from release MacOS]
image

@gdkchan
Copy link
Member

gdkchan commented Mar 3, 2023

This game uses geometry shaders, which MoltenVK (and Metal) does not support. The macos1 release has some code to emulate geometry shaders that was not upstreamed yet. I'm not sure if it's worth upstreaming it since there's some work underway to support geometry shader on MoltenVK by emulating them with mesh shaders. The game should render correctly in theory once the support lands on MoltenVK side or we implement the geometry shader emulation here.

@gdkchan gdkchan added gpu Related to Ryujinx.Graphics os:macOS An issue or feature request exclusively relating to macOS labels Mar 3, 2023
@jneen
Copy link
Author

jneen commented Mar 4, 2023

Thank you!

@B0XGaming
Copy link

This may be related to the issue. This occurs on Windows and you can see the grid lines through objects in anything except 3dw.

Most noticeable in SMB, but is present in SMB, SMB3, SMW and New Soup.

CPU: Ryzen 5 5600X
Memory: 32Gb DDR4
GPU: GTX 1080
OS: Windows 11 Pro 64-Bit 22H2
Ryujinx Version: 1.1.650
Game Version: 3.0.2

bug

@gdkchan
Copy link
Member

gdkchan commented Mar 6, 2023

This is a resolution scale issue and is not related to this problem at all.

@B0XGaming
Copy link

This is a resolution scale issue and is not related to this problem at all.

Alright. Then I'll open a separate bug report. Thank-you.

@AcK77
Copy link
Member

AcK77 commented May 2, 2023

See #4062 for more informations.

@AcK77 AcK77 closed this as completed May 2, 2023
@jneen
Copy link
Author

jneen commented May 2, 2023

Verified still an issue on latest master - is there somewhere else where this was completed?

image

@gdkchan
Copy link
Member

gdkchan commented May 2, 2023

Yea the issue still exists, it should remain open until geometry shaders are supported on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gpu Related to Ryujinx.Graphics os:macOS An issue or feature request exclusively relating to macOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants