Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.f.SidepanelItem does not render SVG Icon #3985

Open
osama571 opened this issue Feb 28, 2024 · 2 comments
Open

sap.f.SidepanelItem does not render SVG Icon #3985

osama571 opened this issue Feb 28, 2024 · 2 comments
Assignees

Comments

@osama571
Copy link

osama571 commented Feb 28, 2024

OpenUI5 version: 1.121.0

Browser/version (+device/version): windows 10/chrome(v. 121.0.6167.189)

Steps to reproduce the problem:

  1. Create a view with sap.f.SidePanel with sap.f.SidePanel items
  2. Give sap.f.SidePanelItem a SVG Icon
  3. the SVG will not be rendered

What is the expected result? SVG should be rendered

What happens instead? SVG does not render

Hallo,
I am using sap.f.SidePanel and I am having hard time to use SVG Icon for SidePanelItem.
the SidepanelItem has a property called Icon, which is of type sap.ui.core.URI (just like the sap.m.Button control).
But I noticed that its only works for font icons. in other hand the sap.m.button does spport SVG Icon
which has the same property and type (sap.ui.core.URI).

So I checked the source code for sap.m.Button and sap.f.SidePanelItem.
I noticed that the Button control uses Image instead of core.Icon if the Icon is not Font.
but it does not do the same for sap.f.SidepanelItem, is this intended behavior or is it just missing feature?

Thanks in advance

@tsanislavgatev tsanislavgatev self-assigned this Feb 29, 2024
@tsanislavgatev
Copy link
Contributor

Hello @osama571 ,

That's a planned behaviour, but we see this as a way for improvement.

We've opened an internal feature request with id DINC0088692.

We will follow up when more information is available.

Best Regards,
Tsanislav

@yurakovay
Copy link

yurakovay commented May 29, 2024

photo_2024-05-29_16-49-06

Hello @tsanislavgatev
I also noticed that when using this control on a mobile device, the icon is not displayed. This can make it unclear to the user what is contained in this block, especially since it's not easy to open.

I undastand that this was indicated as being by design earlier, but now I see that it's not convenient for use, especially on mobile devices.

In the screenshot, I've highlighted the space with the SidePanel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants