-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui5 1.120.11 Unnecessary and unwanted scrollbar on sap.m.TabContainer #4016
Comments
Hi @rpbouman, sorry but according to #5a of CONTRIBUTING.md#requirements-for-a-bug-report I need a running example. Could you please share with us a jsbin sample? |
Hi @aborjinik , thanks for taking the time. I just created this minimal JSBin that reproduces the issue. The preview link is here: https://output.jsbin.com/bapejij and the code is below:
Let me know if you need more! |
@aborjinik is this ok? Can you reproduce it with this? |
Hello @rpbouman, Thank you for sharing this finding. The issue is still reproducible in 1.120, it should be noted in the latest version 1.123 this does not occur. Regards, |
The horizontal scroll appears in all themes after SAPUI5 1.120 due to b09dcb1 PS: when you test, consider that sap_belize is deprecated in SAPUI5 1.120 https://sapui5.hana.ondemand.com/#/topic/38ff8c27b022475a92b591bcf6262551 |
But why? If there is nothing to scroll it's just noise.
I'm sorry but this link is not working. I did find this: https://sapui5.hana.ondemand.com/sdk/#/topic/a87ca843bcee469f82a9072927a7dcdb, is that a reliable source? |
OpenUI5 version: 1.120.11
Browser/version (+device/version): Google Chrome 123.0.6312.58 official, window enterprise 10
Any other tested browsers/devices(OK/FAIL): Ege 122.0.2365.92 has same issue
URL (minimal example if possible): NA
User/password (if required and possible - do not post any confidential information here): NA
Steps to reproduce the problem:
What is the expected result? In ui5 1.108, there is no horizonatal scrollbar.
What happens instead? In 1.120.11 there is, even though the content does not need one
Any other information? (attach screenshot if possible) two screenshots showing same element in v 1.108 and 1.120.
Cause is the line:
overflow-x: scroll
for select .sapMTabContainer .sapMTabContainerContent .sapMTabContainerInnerContent
in https://sapui5.hana.ondemand.com/1.120.11/resources/sap/m/themes/sap_belize/library.css
The text was updated successfully, but these errors were encountered: