Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][1.25.1][Table][A11y][Expected Fixed Time: ASAP] Loss of focus and unable to access interactive content within each row in small screen size #9288

Closed
1 task done
wilson-xu-sap opened this issue Jun 24, 2024 · 8 comments · Fixed by #9428
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC Core

Comments

@wilson-xu-sap
Copy link

wilson-xu-sap commented Jun 24, 2024

Bug Description

#8385
This issue has not been handled. This issue is an reopened one of that.

Affected Component

No response

Expected Behaviour

There is no way to tab inside each row to access the links and quick card within each row in small screen size for example 320px

Isolated Example

https://stackblitz.com/edit/github-xbtmwe?file=src%2FApp.tsx

Steps to Reproduce

  1. Click the URL
  2. Change the screen size to 320px
  3. When using tab key for access the accessible elements from each rows, you will find it cannot be access inside for each row

Log Output, Stack Trace or Screenshots

image

Priority

None

UI5 Web Components Version

1.22.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@wilson-xu-sap wilson-xu-sap added the bug This issue is a bug in the code label Jun 24, 2024
@wilson-xu-sap wilson-xu-sap changed the title Table: [A11y] Loss of focus and unable to access interactive content within each row in small screen size [SF][1.25.1][Table][A11y][Expected Fixed Time: ASAP] Loss of focus and unable to access interactive content within each row in small screen size Jun 24, 2024
@kineticjs kineticjs self-assigned this Jun 24, 2024
@kineticjs
Copy link
Contributor

Hello, @SAP/UI5-webcomponents-topic-core,

The reported issue is that the user cannot access the interactive controls inside the table rows with popin using keyboard..
The described issue also reproduces on the TableSelection.html test page:
-- On a wider screen (when no pop-in) the user can select the "Active" button using 'tab' key (given they previously focused the wrapping row)
-- On a narrower screen (when pop-in is rendered) the tab key does not focus the "Active" button

I could not find in the KBH spec an instruction to select interactive content inside table rows via tab key.
But I found the following recommendation for F2 key instead, which also seems unsupported in ui5-table in popin mode:

KBH spec excerpt:
"F2:
If focus is on a cell, and cell has focusable content, switch keyboard mode from “Navigation” mode to
“Edit” mode. Move focus to the first focusable content control."

Would you please comment if the observed behavior is a bug or a feature?

@kineticjs kineticjs removed their assignment Jul 1, 2024
@nnaydenow nnaydenow self-assigned this Jul 9, 2024
ilhan007 pushed a commit that referenced this issue Jul 10, 2024
Pressing Tab key was moving the focus to the interactive content only if it was placed inside was popin cell. With this change the focus is moved to the interactive content without the need to know in which popin cell it is placed.

Fixes: #9288
@wilson-xu-sap
Copy link
Author

@ilhan007 @nnaydenow Do you have a plan to merge this fix into version 1.xx?

@nnaydenow
Copy link
Contributor

Hi @wilson-xu-sap,

The fix was downported with #9424 and it will be available with the next patch 1.24.8.

@wilson-xu-sap
Copy link
Author

Hi @wilson-xu-sap,

The fix was downported with #9424 and it will be available with the next patch 1.24.8.

Glad to hear that, thanks for your work. 😸

@wilson-xu-sap
Copy link
Author

BTW, when will 1.24.8 release?

@ilhan007
Copy link
Member

Hello @wilson-xu-sap every start of the month we release:

  • minor release for the main code line - 2.1, 2.2
  • and patch for the maintenance code line - 1.24.8, 1.24.9

In case of urgency, we also provide patches sooner, on-demand.
That means either first days of Aug, or sooner in case of urgency.

Is the regular schedule fits your timelines? If not, please give us some details on the urgency matter.

BR,
ilhan

@wilson-xu-sap
Copy link
Author

Hello @wilson-xu-sap every start of the month we release:

  • minor release for the main code line - 2.1, 2.2
  • and patch for the maintenance code line - 1.24.8, 1.24.9

In case of urgency, we also provide patches sooner, on-demand. That means either first days of Aug, or sooner in case of urgency.

Is the regular schedule fits your timelines? If not, please give us some details on the urgency matter.

BR, ilhan

Glad to hear that, thanks.

@wilson-xu-sap
Copy link
Author

We will do the update work after your release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC Core
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants