Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu]: a11y: Menu dialog does not have an accessible name #9313

Closed
1 task done
pankajpandey01 opened this issue Jun 26, 2024 · 4 comments · Fixed by #9574
Closed
1 task done

[Menu]: a11y: Menu dialog does not have an accessible name #9313

pankajpandey01 opened this issue Jun 26, 2024 · 4 comments · Fixed by #9574
Assignees
Labels
ACC bug This issue is a bug in the code SAP SF TOPIC B

Comments

@pankajpandey01
Copy link

Describe the bug

[Menu]: a11y: Menu dialog does not have an accessible name

Isolated Example

No response

Reproduction steps

  1. Go to https://sap.github.io/ui5-webcomponents-react/?path=/story/modals-popovers-menu--default&globals=backgrounds.grid:!false
  2. Open Menu dialog
  3. Run axe tool on browser

Observed error in Axe: ARIA dialog and alertdialog nodes should have an accessible name

Expected Behaviour

accessibleName property should be provided.

Screenshots or Videos

No response

UI5 Web Components for React Version

1.29.0

UI5 Web Components Version

1.24.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@pankajpandey01 pankajpandey01 added the bug This issue is a bug in the code label Jun 26, 2024
@Lukas742
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jun 27, 2024
@kineticjs
Copy link
Contributor

Hi @pankajpandey01 ,

UI5 Web Components provide the prerequisites for screen reader support based on the HTML, ARIA, and WCAG standards. All screen readers that follow those standards should work fine. Nevertheless, there are deviations in the interpretation depending on the combination of browser and screen reader. UI5 Web Components focus on compliance with the standards, rely on automated checks for accessibility and manual tests with reference testing environments.

For Screen Reader Support, we recommend using JAWS 2021 + Chrome (latest), and for HTML/ARIA validation the recommended testing tool is Access Assistant. UI5 Web Components support other environments to the extent of providing a valid HTML and ARIA implementation following the WCAG standards.

Please note that reference testing environments may change over time to reflect changes in the usage of different browsers, their maintenance period, and increased accessibility compliance.

When reporting issues with different testing environments, please ensure that the issue is not false positive, a real accessibility concern is present and there is an impact over the users. Therefore, we recommend to retest the issue using the mentioned reference testing tools and additionally with plain HTML.

In order to process the issues correctly, we would like to have the following information provided:

Issue description
Reference to the suspected violated accessibility requirement (e.g. Web Content Accessibility Guidelines, WCAG 2.0, BITV 2.0, EN 301 549)
Isolated example
Steps to reproduce
UI5 Web Components version
OS/Platform: {...}
Browser: {...}
Testing Tool

Thank you

@kineticjs kineticjs self-assigned this Jun 27, 2024
@kineticjs kineticjs added the ACC label Jun 27, 2024
@pankajpandey01
Copy link
Author

HI @kineticjs
Requested information is provided in description.
Thanks,
Pankaj

@kineticjs kineticjs removed their assignment Jul 1, 2024
@GerganaKremenska GerganaKremenska self-assigned this Jul 8, 2024
@GerganaKremenska
Copy link
Member

Hello @ui5-webcomponents-topic-b I am forwarding this issue to you, because ui5-menu compomnent is missing an accessible name.
To reproduce:

  1. open https://sap.github.io/ui5-webcomponents/components/Menu/
  2. open menu.
  3. in Dev Tools run "Axe".

Missing accessbile name of element with role="dialog". Need to add accessible name to the wrapping responsive popover of the menu.
Screenshot 2024-07-08 at 11 41 10

Best Regards,
Gergana

@GerganaKremenska GerganaKremenska removed their assignment Jul 8, 2024
@unazko unazko self-assigned this Jul 9, 2024
@unazko unazko closed this as completed in a14f6a1 Aug 5, 2024
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Aug 7, 2024
Issue:

Every popover should have an accessible name
according to the accessibility standard.

Fixes: SAP#9313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACC bug This issue is a bug in the code SAP SF TOPIC B
Projects
Status: Completed
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

5 participants