Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The example in the Playground can't be scrolled #9370

Closed
1 of 4 tasks
LidiyaGeorgieva opened this issue Jul 2, 2024 · 2 comments · Fixed by #9475
Closed
1 of 4 tasks

The example in the Playground can't be scrolled #9370

LidiyaGeorgieva opened this issue Jul 2, 2024 · 2 comments · Fixed by #9475
Assignees
Labels
bug This issue is a bug in the code TOPIC Core

Comments

@LidiyaGeorgieva
Copy link
Contributor

Issue Description

No scrolling of the sample possible (the whole page is scrolled and the third notifications group is not fully visible)

Issue Type

  • Documentation is unclear
  • Documentation is incorrect
  • Documentation is missing
  • Other

Steps to reproduce:

  1. Open https://sap.github.io/ui5-webcomponents/nightly/components/fiori/NotificationList/#notification-list-with-group-items
  2. Click on "Open in Playground" button
  3. Expand the two collapsed groups
  4. Issue: no scrolling of the sample possible (the whole page is scrolled and the third notifications group is not fully visible)
    image
@nnaydenow
Copy link
Contributor

Since the sample's height is dynamically we can't guarantee what to be used. You can set some harcoded height to the body element inside the sample

@dimovpetar
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-core ,

I have opened #9475 to set fixed height of the sample.
However, I would like to use 100% height to the body and the html elements, which currently doesn't improve anything, because the iframe has only 150px height. Why 100% height is not the default for all of the samples?

Best regards,
Petar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC Core
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants